From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.26215.1683617774847742875 for ; Tue, 09 May 2023 00:36:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VSrnsURn; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683617773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VNbpJa4nPPHcDVTKmvnAtJsY1zPN2ZjHRVjUbXVmkJA=; b=VSrnsURnbpcxTQTN0MUF+u9kMr0OdaAAvucGoO9crbgppYZW2qlXo8Of6/FnBkgC5xc/3K 2AjGvLoGh9cAV8iwGCfrdGx7AI6B5EcVRn8wQGnpaHQGF2xrcgGhUr1SE0Nn8cGcYLP1A7 bojzjFNnGNtMgsZUaZlMem+w+H9vGW8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-533-iRzJKhcPOqiQKSW3CO1G3g-1; Tue, 09 May 2023 03:36:10 -0400 X-MC-Unique: iRzJKhcPOqiQKSW3CO1G3g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 246D480C8D0; Tue, 9 May 2023 07:36:09 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFC65C16024; Tue, 9 May 2023 07:36:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8F7BE1801081; Tue, 9 May 2023 09:36:07 +0200 (CEST) Date: Tue, 9 May 2023 09:36:07 +0200 From: "Gerd Hoffmann" To: Pedro Falcato Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , Corvin =?utf-8?B?S8O2aG5l?= , Sebastien Boeuf , Anthony Perard , Julien Grall , Laszlo Ersek Subject: Re: [PATCH 0/2] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Message-ID: References: <20230508215246.217002-1-pedro.falcato@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230508215246.217002-1-pedro.falcato@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 08, 2023 at 10:52:44PM +0100, Pedro Falcato wrote: > This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one. > They were both forked from the same code, and are code-and-functionality similar. As such, there > seems to be no need for duplication here. > > First I manually replayed OvmfPkg/SataControllerDxe's patches on top of the generic one. Only one > seemed to make sense. The second patch removes OvmfPkg/SataControllerDxe and replaces it for all platforms > under OvmfPkg. > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > More testing from other, alternative platforms is desired, although breakage seems unlikely. > > (+CC Laszlo as the author of the original SataControllerDxe patches) Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann take care, Gerd