From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3BC0094155F for ; Mon, 13 Nov 2023 10:54:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Tq4Fosj+WCzgVmG3pnaLYV+XQL837DxnVjIlR0IgYDU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1699872871; v=1; b=RmkEn31KcLzrJnXxY+YggoOOBj6MJWb52aGWzW4st4Psz9IvCt6OAhAnKW6G+lGgjlapqjod eSfsbGa8k2vAnIqXf7ZwjPrZDhQIbyMcvV6zCk2oMlVf6+jMvwNFnPTZccaHoGkzGDAdxTz80rm qrzSr4TEMp6OsBWkVUoqiFTc= X-Received: by 127.0.0.2 with SMTP id VNXxYY7687511x86YAXZkX9U; Mon, 13 Nov 2023 02:54:31 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.34354.1699872871030383220 for ; Mon, 13 Nov 2023 02:54:31 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-PQgk1HwIPlSdAL5mYraOXQ-1; Mon, 13 Nov 2023 05:54:25 -0500 X-MC-Unique: PQgk1HwIPlSdAL5mYraOXQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82CA92806664; Mon, 13 Nov 2023 10:54:25 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4023640C6EB9; Mon, 13 Nov 2023 10:54:25 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EE9EB1804A63; Mon, 13 Nov 2023 11:54:23 +0100 (CET) Date: Mon, 13 Nov 2023 11:54:23 +0100 From: "Gerd Hoffmann" To: xieyuanh Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [Patch V4] UefiCpuPkg/MpInitLib: Enable execute disable bit. Message-ID: References: <20231113055948.1773-1-yuanhao.xie@intel.com> MIME-Version: 1.0 In-Reply-To: <20231113055948.1773-1-yuanhao.xie@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pAH7GoH6oFcU2KSDHLdeYYNLx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RmkEn31K; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 9a6ec5db5c..f29e66a14f 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -910,9 +910,16 @@ DxeApEntryPoint ( > CPU_MP_DATA *CpuMpData > ) > { > - UINTN ProcessorNumber; > + UINTN ProcessorNumber; > + MSR_IA32_EFER_REGISTER EferMsr; > > GetProcessorNumber (CpuMpData, &ProcessorNumber); > + if (CpuMpData->EnableExecuteDisableForSwitchContext) { > + EferMsr.Uint64 = AsmReadMsr64 (MSR_IA32_EFER); > + EferMsr.Bits.NXE = 1; > + AsmWriteMsr64 (MSR_IA32_EFER, EferMsr.Uint64); > + } It helps reviewers if you document changes from one version to the next. This code block was moved (compared to v3). Why? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111138): https://edk2.groups.io/g/devel/message/111138 Mute This Topic: https://groups.io/mt/102556608/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-