Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti

["Gerd Hoffmann" <kraxel@redhat.com>]

On Wed, Aug 16, 2023 at 10:22:30PM +0200, Ard Biesheuvel wrote:
> On Wed, 16 Aug 2023 at 22:13, Michael Roth <michael.roth@amd.com> wrote:
> >
> > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when
> > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is
> > true by default, but needs to be disabled for QEMU/OVMF where early INIT
> > is not simulated. Commit 1d76560146 ("OvmfPkg: Disable
> > PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it
> > by default for OvmfPkg, but a similar change was not made for the
> > AmdSev package. This breaks booting of SEV and SNP guests.
> >
> > Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev
> > package, as was previously done for OvmfPkg variants.
> >
> > Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.")
> > Cc: YuanhaoXie <yuanhao.xie@intel.com>
> > Cc: Tom Lendacky <Thomas.Lendacky@amd.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Signed-off-by: Michael Roth <michael.roth@amd.com>
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> Apologies for the oversight. This should be included in the upcoming stable tag.

Including into the stable tag didn't work out, but can we merge it now
please?

thanks,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108282): https://edk2.groups.io/g/devel/message/108282
Mute This Topic: https://groups.io/mt/100787520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-