From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E733194185B for ; Tue, 5 Sep 2023 13:33:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Imev2i6K3jmsZ99o6vgX+yiA9qc+LE1Vb2cBnsh9d7U=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693920822; v=1; b=WyDFvUsMGof4ZvgVhzOkZ/AV+SLeofPfQenFNzUCdpIzIC3w8UiV6m6y4Z4O0Zu8dzt03dHx e75hsfpzQ5f7mekT+5l6Q9dQmrIZNdbaDBUji1oDvYHGcwqtlh7GqIX+LJs+8MWHqYpUDu+F85s CjunMDAl3SV2iBpavT4cRfrY= X-Received: by 127.0.0.2 with SMTP id wODgYY7687511xDaFGjOZrRr; Tue, 05 Sep 2023 06:33:42 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.21368.1693920821696891762 for ; Tue, 05 Sep 2023 06:33:42 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-NK1MLIKoMiiY1aE-Y9Idog-1; Tue, 05 Sep 2023 09:33:35 -0400 X-MC-Unique: NK1MLIKoMiiY1aE-Y9Idog-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B13468164E0; Tue, 5 Sep 2023 13:33:34 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6DE96B5AA; Tue, 5 Sep 2023 13:33:32 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 17F7E1806172; Tue, 5 Sep 2023 15:33:31 +0200 (CEST) Date: Tue, 5 Sep 2023 15:33:31 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: Michael Roth , "Liming Gao (Byosoft address)" , devel@edk2.groups.io, YuanhaoXie , Tom Lendacky , Eric Dong , Ray Ni , Rahul Kumar , Jiewen Yao , Jordan Justen , Erdem Aktas , James Bottomley , Min Xu Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti Message-ID: References: <20230816201146.1634348-1-michael.roth@amd.com> <20230816201146.1634348-3-michael.roth@amd.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HJWGT98a5WpgC9PL6mK4kaogx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WyDFvUsM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Aug 16, 2023 at 10:22:30PM +0200, Ard Biesheuvel wrote: > On Wed, 16 Aug 2023 at 22:13, Michael Roth wrote: > > > > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when > > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is > > true by default, but needs to be disabled for QEMU/OVMF where early INIT > > is not simulated. Commit 1d76560146 ("OvmfPkg: Disable > > PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it > > by default for OvmfPkg, but a similar change was not made for the > > AmdSev package. This breaks booting of SEV and SNP guests. > > > > Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev > > package, as was previously done for OvmfPkg variants. > > > > Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.") > > Cc: YuanhaoXie > > Cc: Tom Lendacky > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > Cc: Gerd Hoffmann > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Min Xu > > Signed-off-by: Michael Roth > > Reviewed-by: Ard Biesheuvel > > Apologies for the oversight. This should be included in the upcoming stable tag. Including into the stable tag didn't work out, but can we merge it now please? thanks, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108282): https://edk2.groups.io/g/devel/message/108282 Mute This Topic: https://groups.io/mt/100787520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-