public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann via groups.io" <kraxel=redhat.com@groups.io>
To: devel@edk2.groups.io, mitchell.augustin@canonical.com
Cc: xpahos@gmail.com
Subject: Re: [edk2-devel] [BUG] Extremely slow boot times with CPU and GPU passthrough and host phys-bits > 40
Date: Wed, 20 Nov 2024 12:26:53 +0100	[thread overview]
Message-ID: <byqr63sxho6xgwkgivs5wfvt6t6wnantv54p4bhcrlayvhvh2p@zsl3m7hxfcyf> (raw)
In-Reply-To: <24085.1732055112128290386@groups.io>

On Tue, Nov 19, 2024 at 02:25:12PM -0800, mitchell.augustin via groups.io wrote:
> Hi,
> 
> Thanks for the suggestion. I'm not necessarily saying this patch
> itself has an issue, just that it is the point in the git history at
> which this slow boot time issue manifests for us. This may be because
> the patch does actually fix the other issue I described above related
> to BAR assignment not working correctly in versions before that patch,
> despite boot being faster back then. (in those earlier versions, the
> PCI devices for the GPUs were passed through, but the BAR assignment
> was erroneous, so we couldn't actually use them - the Nvidia GPU
> driver would just throw errors.)

Do you also see the slowdown without the GPU in a otherwise identical
guest configuration?

While debugging a similar issue I've found that kvm behaves differently
in case a PCI-assigned device is present, specifically kvm goes look
more closely at memory attributes in guest page tables and mtrr
registers and uses them for EPT configuration.  See commit ce4c76e46d52
("OvmfPkg/Sec: Setup MTRR early in the boot process.").

So this could be an issue in kvm.  It could also be ovmf doing something
wrong with page attributes and mtrr settings.

> After I initially posted here, we also discovered another kernel issue
> that was contributing to the boot times for this config exceeding 5
> minutes - so with that isolated, I can say that my config only takes
> about a 5 minutes for a full boot: 1-2 minutes for `virsh start`
> (which scales with guest memory allocation),

Looks quite high to me.  What amount of guest memory we are talking
about?

> I'm going to attempt to profile ovmf next to see what part of the code
> path is taking up the most time, but if you already have an idea of
> what that might be (and whether it is actually a bug or expected to
> take that long), that insight would be appreciated.

More details would be helpful indeed.  Is that a general overall
slowdown?  Is it some specific part which takes alot of time?  I'd
suggest to also trim down the logging, it's quite excessive in the build
(apparently every single memory allocation is logged), that slows down
the boot process too.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120804): https://edk2.groups.io/g/devel/message/120804
Mute This Topic: https://groups.io/mt/109651206/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-11-20 11:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 16:46 [edk2-devel] [BUG] Extremely slow boot times with CPU and GPU passthrough and host phys-bits > 40 mitchell.augustin via groups.io
2024-11-18 21:14 ` xpahos via groups.io
2024-11-19 22:25   ` mitchell.augustin via groups.io
2024-11-20  9:35     ` xpahos via groups.io
2024-11-20 11:26     ` Gerd Hoffmann via groups.io [this message]
2024-11-20 15:20       ` mitchell.augustin via groups.io
2024-11-20 20:00         ` mitchell.augustin via groups.io
2024-11-21 12:32         ` Gerd Hoffmann via groups.io
2024-11-22  0:23           ` mitchell.augustin via groups.io
2024-11-22 10:35             ` Gerd Hoffmann via groups.io
2024-11-22 17:38               ` Brian J. Johnson via groups.io
2024-11-22 22:32               ` mitchell.augustin via groups.io
2024-11-24  2:05                 ` mitchell.augustin via groups.io
2024-11-25 11:47                   ` Gerd Hoffmann via groups.io
2024-11-25 19:58                     ` mitchell.augustin via groups.io
2024-11-26  8:09                       ` Gerd Hoffmann via groups.io
2024-11-26 22:27                         ` mitchell.augustin via groups.io
2024-12-04 14:56                           ` mitchell.augustin via groups.io
2024-11-25 11:18                 ` Gerd Hoffmann via groups.io
2024-11-18 21:32 ` Ard Biesheuvel via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=byqr63sxho6xgwkgivs5wfvt6t6wnantv54p4bhcrlayvhvh2p@zsl3m7hxfcyf \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox