From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id AF6BD1A1E06
 for <edk2-devel@ml01.01.org>; Fri,  2 Sep 2016 04:19:40 -0700 (PDT)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 39BD1C08E293;
 Fri,  2 Sep 2016 11:19:40 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.phx2.redhat.com
 [10.3.116.76])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u82BJc7d020586; Fri, 2 Sep 2016 07:19:39 -0400
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@ml01.01.org
References: <1472666379-25426-1-git-send-email-ard.biesheuvel@linaro.org>
 <1472666379-25426-3-git-send-email-ard.biesheuvel@linaro.org>
Cc: leif.lindholm@linaro.org
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <c0005127-6031-238d-1157-008b89f033ce@redhat.com>
Date: Fri, 2 Sep 2016 13:19:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1472666379-25426-3-git-send-email-ard.biesheuvel@linaro.org>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Fri, 02 Sep 2016 11:19:40 +0000 (UTC)
Subject: Re: [PATCH v2 2/6] ArmVirtPkg/FdtPciPcdProducerLib: add handling of PcdPciIoTranslation
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2016 11:19:40 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 08/31/16 19:59, Ard Biesheuvel wrote:

> +    if (!EFI_ERROR (Status) && RegSize == 2 * sizeof(UINT64)) {

Before you commit this patch, please insert a space character between
"sizeof" and "(".

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Please hold on for a little while before committing the series, I'd like
to test it quickly.

Thanks!
Laszlo