From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8CAC482127 for ; Mon, 13 Feb 2017 06:18:02 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id k90so24280030wrc.3 for ; Mon, 13 Feb 2017 06:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=YcFd9gUYMhO0JpV5AtrGHxy7qBznfDGukyv+ua0BrNg=; b=U8pNyZ73ij/foBv17tISuStmBZXHkt0zIfa+9yQ45TAhlFQV8JnVkW/jI8it8l8S8e tboE4iAUSWs7XfY+nujReC66Rx/gUnec6wj6UYlPy+NU3I6iwCHvZEBGzMt1Ag6inw0G AD+ikPurZMsIhS4zuVzinQ2TPifwi5CHlM0YDBsa94+sipZb9VBPvoIrGVnC+bhLX5GA mf/E3us3ylHIv21oGNn62SqNDfQKnop4KJk4xwtJ9Ao1sembJ/RzSIlNUULPSbj7GpVG Gd1HYJ6CaT32R85ol+KMZa+GtPM6W41FGR4iRCDGNljejEVdGps4ZgXDdFpQ1sMm1zsH wQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=YcFd9gUYMhO0JpV5AtrGHxy7qBznfDGukyv+ua0BrNg=; b=SNlPyAIFmnEKBeXhngyVfv4sV5Tq+C9tbP2BYPtvgnsyUsjUvHy+n23BFfb68w6AWM NWxw1TXym+PNwUuALxGXd2x3eMxxsLdz/T/4zUm8PCm6o4SQkRl2BrwF8kyHEB5iA2Wx HB2vtKqyy1AJ3DqZnZH5GT53+QcYZ06xO1s5eMGHhAQrBWkDMZJLrfIN3XM284pbWZO0 qY5fuQ2wumcB13FZZAgnrPeOzaVWZEYRRB+H5HOw1nzlHluh0XoC4Wtm2VkUk60Yy27A 22mVe7sp3WZztSK4hgPtpw5gdK8Fw+YOZ3MLv9qnXFaTRb/3WFQjSkGdxY1oTISxjovO BqUA== X-Gm-Message-State: AMke39lwqhvnLb1eDv5F/XeMXweCXIxbhNcZCepYQ26Ssmx8XwG35IrYtmr95KRyB3I1+w== X-Received: by 10.223.171.149 with SMTP id s21mr20201714wrc.64.1486995481051; Mon, 13 Feb 2017 06:18:01 -0800 (PST) Received: from [192.168.10.165] (94-39-187-56.adsl-ull.clienti.tiscali.it. [94.39.187.56]) by smtp.googlemail.com with ESMTPSA id x135sm5549511wme.23.2017.02.13.06.18.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 06:18:00 -0800 (PST) Sender: Paolo Bonzini To: "Zhu, Yonghong" , "edk2-devel@ml01.01.org" References: <20170213125400.27421-1-pbonzini@redhat.com> Cc: "Gao, Liming" From: Paolo Bonzini Message-ID: Date: Mon, 13 Feb 2017 15:18:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] VfrCompile: fix invalid comparison between pointer and integer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 14:18:02 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 13/02/2017 14:55, Zhu, Yonghong wrote: > Hi Paolo Bonzini, > > We already had another patch for this issue. Please help to check the attachment. Thanks. Is it intended that "-s ''" is not an error, rather it is the same as no option at all? Paolo > Best Regards, > Zhu Yonghong > > > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > Sent: Monday, February 13, 2017 8:54 PM > To: edk2-devel@ml01.01.org > Cc: Zhu, Yonghong ; Gao, Liming > Subject: [PATCH] VfrCompile: fix invalid comparison between pointer and integer > > This would be valid C but is not valid C++, so change the comparison to do what it has always been doing. > > Signed-off-by: Paolo Bonzini > --- > BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > index 3ca57ed..2f97975 100644 > --- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > +++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > @@ -3372,7 +3372,7 @@ CVfrStringDB::GetVarStoreNameFormStringId ( > UINT8 BlockType; > EFI_HII_STRING_PACKAGE_HDR *PkgHeader; > > - if (mStringFileName == '\0' ) { > + if (mStringFileName == NULL) { > return NULL; > } > > -- > 2.9.3 > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >