From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.25924.1574353050266889095 for ; Thu, 21 Nov 2019 08:17:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gQEgV8/k; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574353049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xeGGSYEieHsHs7Bj9OFzxs9pavBiPBss4b+y59cpeT0=; b=gQEgV8/kWTFsLGlVJYj7UU9R0xyylhmPeyvoIYVku0VdzW5tx6oKNM09FXEzvvF5hXQsT5 v9ZKZcHLOcuXAJ7z4rw5YYkE80QT6SH76paTJwAWc45+ZxC0eOwN/fFWMjs3yCP666bHN9 rN7NrVSFT/AcgUZVfckSkiTEhXNbPvQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-Iq2rQXW5NbCfhGS5h_TQ_w-1; Thu, 21 Nov 2019 11:17:27 -0500 Received: by mail-wm1-f70.google.com with SMTP id f16so1796531wmb.2 for ; Thu, 21 Nov 2019 08:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PET62GZb36NBeMhakrG3N8CYmzypvCEQvZXjljLvv2A=; b=WTU1Pcta43D06edSG0tq6OSAKEbBJhuvpWd/Bk7HoINCwpDGcrP6fSSjf66dI1BHqu VSdPA5CaAMDw7JRFAgJg7PJLQlqc6tBG46jixhsKDBTUIR7NkeI5QErR6ZZhseYKRymL AHKk+0iAMWvGI3QAJ/IS9FuCykgRoUMwJXQQ+v/l3mnFaAlYU2Lj73ywa83RyCsRqfc2 4gGWE22Tvk8BU66ny3oBIkwBqeu93+K1MKq7ZnTxVOKX2vhTaP/g9xeSEky6ZBksMc8G /dAj8SA8Qj5dFNbfgKLeulCNXgCTJfwX788FBur9TfNyWwARQLIkHd6CZxY3Y2QLHQYK q3Kw== X-Gm-Message-State: APjAAAVr3CcaOD9Nm2LJ7FZXhRaIKMIMjEz3zBUEVtrjZRXxGZQPlvgO FGAKrnTEj5nLuPGPjdpR0gE4OybYgKQRJ5UPHAtTSJlfHRqv9Kgl7Ys6e/nElROXH6vlT6q+Dax 7iS/OgGyPr6hLyw== X-Received: by 2002:a1c:9986:: with SMTP id b128mr3911289wme.154.1574353045910; Thu, 21 Nov 2019 08:17:25 -0800 (PST) X-Google-Smtp-Source: APXvYqz0m8bPQsz7flAoMgBLIZ+Oerdhjex99M9j2u1v/C5rP2FVcOFjAl6t3jx4fyBZyT35bXrIIQ== X-Received: by 2002:a1c:9986:: with SMTP id b128mr3911269wme.154.1574353045657; Thu, 21 Nov 2019 08:17:25 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id 16sm118568wmf.0.2019.11.21.08.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 08:17:25 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix 'missing header' warnings To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20191121155443.2320-1-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 21 Nov 2019 17:17:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121155443.2320-1-sami.mujawar@arm.com> X-MC-Unique: Iq2rQXW5NbCfhGS5h_TQ_w-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 11/21/19 4:54 PM, Sami Mujawar wrote: > The Basetools scripts have been updated to report > warnings if header files are not listed in the > [Sources] section of the inf files. >=20 > Update the inf files to include the respective > header files to fix the reported warnings. >=20 > CC: Alexei Fedorov > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/686_dynamic_tables_fix_include_w= arning_v1 >=20 > Notes: > v1: > - Fix missing header warnings = [SAMI] >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.= inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf = | 3 ++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf = | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTable= FactoryDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTab= leFactoryDxe.inf > index b47a690dd72702a2d7157cbb21249ba1d01d08cd..920aa81e31b402cae645d919e= e6559d8c9bde136 100644 > --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory= Dxe.inf > +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory= Dxe.inf > @@ -23,6 +23,7 @@ [Defines] > [Sources] > AcpiTableFactory/AcpiTableFactory.c > DeviceTreeTableFactory/DeviceTreeTableFactory.c > + DynamicTableFactory.h > DynamicTableFactoryDxe.c > SmbiosTableFactory/SmbiosTableFactory.c > =20 > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLib= Arm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.i= nf > index 3bbd0e7818c6172f9178b12a3d0960e2d298bca1..2f987e3b6d339d4b5f342cb52= b8dc712cf4e585c 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > @@ -1,7 +1,7 @@ > ## @file > # IORT Table Generator > # > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -18,6 +18,7 @@ [Defines] > =20 > [Sources] > IortGenerator.c > + IortGenerator.h > =20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLib= Arm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.i= nf > index 3cb13d7d8fd3df04f3e16cc6161d9736f7579a80..2c7d19513d6ceea29fd9f271f= 983a6cf6d2c1046 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf > @@ -18,6 +18,7 @@ [Defines] > =20 > [Sources] > PpttGenerator.c > + PpttGenerator.h > =20 > [Packages] > EmbeddedPkg/EmbeddedPkg.dec >=20 Reviewed-by: Philippe Mathieu-Daude