From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.9757.1589194844499299068 for ; Mon, 11 May 2020 04:00:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=cptaq1+6; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id v12so10336395wrp.12 for ; Mon, 11 May 2020 04:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rPOonF+j8fTK+YcsJqPWS0uoZckS8M8uXExi9yuAcIg=; b=cptaq1+6MLKouXSnVcdkTkC2OZu405HovTJ60Ilzi+gX4I/y5wEpMkVEq2GLwcYGGH 9SBU8zYI7R63JPpVx0Mc9zPcW7WdXHYs0hx7eO8EFwD5ZxZ6XOhSkEWFmxNQ4FjWDTeI jjQr7gH8/Drm/yZxegY+HZG83dQMKJhreOG0++U3HC+oxMgdhmcP7AqdWK8cgUWI4q7q YMCCe4pVNQbScXGDCIjH+BLlUrSIeazK3GZVfN2PIqtH/h4zwzMrpgI5Wj/Q7tTEgnOf ryGf1IWBHTqYUh8oMGe+stYBj9AOKR+wg3ojoNHaQHpO6crGr75HmsKV/5UycnwtEQbW VR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rPOonF+j8fTK+YcsJqPWS0uoZckS8M8uXExi9yuAcIg=; b=E6oticODbtDuHqcFeSO6g+8wX39gtn3MvhUXHUjz65IHTrKMQFGsMQWGeVg3wVDSoa PhC0dnkiLmVAWxvRpi2/usQ/EzDjCbXbOLfa8stiNoPaWHCHBKElASamsGCgpU9ZBNRW yO0lTBJU+DuSQyZkbep4Jus0GZy+vmDnTcgRVZlkgOQhWt7cmj2JC6yKtEkpPgDcMpCM w/o27rr4ImLjQXzPB8XpuzFQVcueMu3XtA9QA3sFUauqKSpoPgwzHxyRYbFOYGBOv+6K kli3050Y9GP7HFFS0zCZzWjkFrmR3d89/JMHJt6/Ddn09LUjEffy/PlP+IIDBb87hoTM y8JA== X-Gm-Message-State: AGi0PuZwIfaXpbaUoOEEzcLZnsu8wSX2EXm0lopR7KgLv5BjpbxPthGj cBcFHmt9wIyUzbG5vjCGYIHpCw== X-Google-Smtp-Source: APiQypKDBCNL9yw+32SfYCZ29260zO3YvwK75t+gsO7ydkfjHqiB55IDTWrEnf9znVFDWMYmLSlZVQ== X-Received: by 2002:adf:d849:: with SMTP id k9mr18406024wrl.304.1589194843133; Mon, 11 May 2020 04:00:43 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.75.87]) by smtp.googlemail.com with ESMTPSA id x23sm25545569wmj.6.2020.05.11.04.00.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 04:00:42 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode To: devel@edk2.groups.io, Andrei Warkentin Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com References: <20200510213603.12741-1-andrey.warkentin@gmail.com> <160DF42BB1B94275.21511@groups.io> From: "Pete Batard" Message-ID: Date: Mon, 11 May 2020 12:00:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <160DF42BB1B94275.21511@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Actually forgot one thing on this one: Subject line should say "RPi" not "RPi3" since it affects both Pi's. /Pete On 2020.05.11 11:58, Pete Batard via groups.io wrote: > On 2020.05.10 22:36, Andrei Warkentin wrote: >> The scaled resolutions are useful, but are not the default expected >> by most users. Linux and BSDs don't set preferred resolution in >> their OS loader, so when booting via setup UI, the OS is left >> running at 800x600, not the native resolution. This looks crummy. >> >> Signed-off-by: Andrei Warkentin >> --- >>   Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++- >>   Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++- >>   2 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >> b/Platform/RaspberryPi/RPi3/RPi3.dsc >> index a138c874..8dd4cbff 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >> @@ -471,7 +471,11 @@ >>     # >>     # Display-related. >>     # >> - >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f >> >> + >> +  # >> +  # Just enable native resolution by default. >> +  # >> + >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 >> >> >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 >> >>     # >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index 75867f03..9413fe66 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -486,7 +486,11 @@ >>     # >>     # Display-related. >>     # >> - >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f >> >> + >> +  # >> +  # Just enable native resolution by default. >> +  # >> + >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 >> >> >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 >> >>     # >> > > Reviewed-by: Pete Batard > > For the series: > Tested-by: Pete Batard > > >