From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
Ray Ni <ray.ni@intel.com>, Abner Chang <abner.chang@hpe.com>,
Nickle Wang <nickle.wang@hpe.com>
Subject: Re: [edk2-devel] [PATCH v4 6/8] EmulatorPkg: Add VariableFlashInfoLib
Date: Wed, 20 Apr 2022 18:51:47 -0400 [thread overview]
Message-ID: <c01bdb1c-28ce-2b38-d54f-d44c1a3f6e89@linux.microsoft.com> (raw)
In-Reply-To: <16E5331AC6E8EA6F.9041@groups.io>
Hi EmulatorPkg maintainers,
This is the only package in the series that has not given a review yet.
Can you please help review it?
Thanks,
Michael
On 4/12/2022 12:29 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance of VariableFlashInfoLib to the platform build as
> it is a new library class introduced in MdeModulePkg.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> EmulatorPkg/EmulatorPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 554c13ddb500..4cf886b9eac7 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -122,6 +122,7 @@ [LibraryClasses]
> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
> SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
next prev parent reply other threads:[~2022-04-20 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 16:29 [PATCH v4 0/8] Add Variable Flash Info HOB Michael Kubacki
2022-04-12 16:29 ` [PATCH v4 1/8] MdeModulePkg: " Michael Kubacki
2022-04-25 16:05 ` [edk2-devel] " Sami Mujawar
2022-04-12 16:29 ` [PATCH v4 2/8] MdeModulePkg/VariableFlashInfoLib: Add initial library Michael Kubacki
2022-04-25 16:05 ` [edk2-devel] " Sami Mujawar
2022-04-25 22:21 ` Michael Kubacki
2022-04-12 16:29 ` [PATCH v4 3/8] MdeModulePkg/Variable: Consume Variable Flash Info Michael Kubacki
2022-04-25 16:05 ` [edk2-devel] " Sami Mujawar
2022-04-12 16:29 ` [PATCH v4 4/8] MdeModulePkg/FaultTolerantWrite: " Michael Kubacki
2022-04-25 16:05 ` [edk2-devel] " Sami Mujawar
2022-04-12 16:29 ` [PATCH v4 5/8] ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib Michael Kubacki
2022-04-25 16:06 ` Sami Mujawar
2022-04-12 16:29 ` [PATCH v4 6/8] EmulatorPkg: " Michael Kubacki
2022-04-12 16:29 ` [PATCH v4 7/8] OvmfPkg: " Michael Kubacki
2022-04-19 19:26 ` Rebecca Cran
2022-04-12 16:29 ` [PATCH v4 8/8] UefiPayloadPkg: " Michael Kubacki
2022-04-14 3:02 ` [edk2-devel] " Guo Dong
2022-04-20 7:43 ` [PATCH v4 0/8] Add Variable Flash Info HOB Ard Biesheuvel
[not found] ` <16E5331AC6E8EA6F.9041@groups.io>
2022-04-20 22:51 ` Michael Kubacki [this message]
2022-04-21 1:51 ` [edk2-devel] [PATCH v4 6/8] EmulatorPkg: Add VariableFlashInfoLib Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c01bdb1c-28ce-2b38-d54f-d44c1a3f6e89@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox