From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web08.14714.1650495109615404502
 for <devel@edk2.groups.io>;
 Wed, 20 Apr 2022 15:51:49 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=XLxeheX/;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.46.36])
	by linux.microsoft.com (Postfix) with ESMTPSA id 607DF20E2D2F;
	Wed, 20 Apr 2022 15:51:48 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 607DF20E2D2F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1650495109;
	bh=ZZHH6C/tySbIfHN8jhLFZ5DMpBL43PdS666F5nHXovk=;
	h=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;
	b=XLxeheX/TJAGapgk3cJHxxR0Di0nnIVVrU5vy7QlONPwO0iRFZowOnRmLXDysncMx
	 Z0Sd2eJfdE8lfTyFfxhaFOF1qiSo2q52pWw4rg20pI4d41+I3IA60QvD8dU3InuWlo
	 YdeaIKD3P/Fvh5m1YBoVXroRV0kQJNyxh7jtnR4U=
Message-ID: <c01bdb1c-28ce-2b38-d54f-d44c1a3f6e89@linux.microsoft.com>
Date: Wed, 20 Apr 2022 18:51:47 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [edk2-devel] [PATCH v4 6/8] EmulatorPkg: Add VariableFlashInfoLib
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
 Ray Ni <ray.ni@intel.com>, Abner Chang <abner.chang@hpe.com>,
 Nickle Wang <nickle.wang@hpe.com>
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <20220412162940.4978-1-mikuback@linux.microsoft.com>
 <16E5331AC6E8EA6F.9041@groups.io>
In-Reply-To: <16E5331AC6E8EA6F.9041@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi EmulatorPkg maintainers,

This is the only package in the series that has not given a review yet. 
Can you please help review it?

Thanks,
Michael

On 4/12/2022 12:29 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance of VariableFlashInfoLib to the platform build as
> it is a new library class introduced in MdeModulePkg.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   EmulatorPkg/EmulatorPkg.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 554c13ddb500..4cf886b9eac7 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -122,6 +122,7 @@ [LibraryClasses]
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>     ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>     FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf