From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Thu, 18 Jul 2019 10:01:44 -0700 Received: by mail-wr1-f67.google.com with SMTP id g17so29501893wrr.5 for ; Thu, 18 Jul 2019 10:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3mRhFP9sCZTM2x1SunqTWrjU0mRjQGXUDIZu9EfoGSI=; b=f1E5P1C6OgDCPwGboGweguJW5v55NmMiqJ2aNdBCNCH1qzg8W8utafcTgCRjVkc/yS j1r0bdJuKTnc6kcH+dB1h50SoevuCLW87gEOaHpHvmqsfqNO2ZygBisdY9p41rZPXXxe yN3AHkf7Xyz6J9r/Ry/Ii3R+nzlXqzf+ucHkeY4tYL5tkm/c+8j4RGfh7mEuFQMD217E u1qYBWLLFeUTbWK/BkAlrfbFB8SiqRoU6sit3J0Ed0ABXqRwzJ7XHInaAyD53qYtv+sq vUsnlJvrUb1bd79EDscNDI6yoH/hWXbXgukitzrw4xdyqjjudDVucEtUMqmAbTbVYLQc he+w== X-Gm-Message-State: APjAAAWZXzimvJhpXUbadZ9bUNPFT2oP+TNr76TtXKkWj8lpRZHa7Q/y 8/wm4/Ux1ucnQhZ0jeZsq399vw== X-Google-Smtp-Source: APXvYqwRTqKclsisDlHfXt9KN9WfmC91YPlfwYGaHl6jytAvkHFqbnvLTvDroyQ/LKGCE/0bGSFEUw== X-Received: by 2002:adf:db8e:: with SMTP id u14mr25900344wri.314.1563469302581; Thu, 18 Jul 2019 10:01:42 -0700 (PDT) Return-Path: Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id j189sm29804401wmb.48.2019.07.18.10.01.41 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2019 10:01:41 -0700 (PDT) Subject: Re: [PATCH 0/3] add GetMaintainer.py helper script To: Leif Lindholm , edk2-devel-groups-io Cc: Andrew Fish , Laszlo Ersek , Michael D Kinney , Bob Feng , Liming Gao , "Wu, Hao A" , Stefan Berger References: <20190712170128.6495-1-leif.lindholm@linaro.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 18 Jul 2019 19:01:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Leif, On 7/18/19 6:27 PM, Leif Lindholm wrote: > Laszlo, Hao - I have prepared a set for pushing as below. > > (Reviewed-by: Leif Lindholm > for all of your patches.) > *But*, I need a review from  Bob and/or Liming before I push the final one: > "BaseTools: add GetMaintainer.py script" - > https://edk2.groups.io/g/devel/message/43666 > > I have verified reviews/acks by all affected reviewers, except for > Stefan Berger for Ovmf TCG/TPM2. > While I would prefer to have that too, this is a file format shift - not > a change in responsibility areas. As Marc-André and Stefan have the same responsabilities, Marc-André's review for their common section should be sufficient, right? Now if you want to be kind and patient with Stefan, since this is not a logical change blocking anyone, it might be wise to wait over the weekend. My 2 cents ;) Phil. > Laszlo, do you agree? > If so, I can push 1-7/8 as is. > > / >     Leif > > Hao A Wu (1): >   Maintainers.txt: Fine-grained review ownership for MdeModulePkg > > Laszlo Ersek (4): >   Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" >   Maintainers.txt: split out section "OvmfPkg: Xen-related modules" >   Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related >     modules" >   Maintainers.txt: split out section "OvmfPkg: CSM modules" > > Leif Lindholm (3): >   Maintainers.txt: update for filesystem area descriptions >   Maintainers.txt: add wildcard path association for Arm/AArch64 >   BaseTools: add GetMaintainer.py script > > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm > wrote: > > Changes are available directly from: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1 > > This series adds new tags to the Maintainers.txt format, making it > possible > to describe which filesystem paths are looked after by which people, and > hence automating the extraction of a list over who should be cc:d on > a patch > submission. > > Remaining shorcomings in v1: > - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines >   interspersed with the tag lines. These lines will be removed as > areas of >   responsibility is formally rewritten as tags. > - * Wildcard support is not fully filesystem compliant except in > first or >   last position in the file pattern (it translates as regex .* > elsewhere). >   However, actual cases of mismatch are expected to be unlikely, and > they >   will be false positives rather than false negatives - so I think > this is >   good enough at least for a start. > - Provides no information of why certain people or meiling lists were >   picked - it just bundles all recipients up, deduplicates them, and >   prints them out. > > Using the script requires the gitpython module to be installed. > > Worthwhile mentioning outside the ChangeLog is the added -l flag, which > lets you look up what a given path would return in the way of matches. > E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > would return: > --- > Non/Existing/Path > "Non/Existing/Path": no maintainers found, looking for default >   Andrew Fish > >   Laszlo Ersek > >   Leif Lindholm > >   Michael D Kinney > >   devel@edk2.groups.io > --- > > This series would still result in GetMaintainers.py missing some > maintainers/reviewers due to descriptions in prose rather than filename > patterns. My preferred way of handling this would be to merge 1-2/3 as > soon as found acceptable, following up and merging patches to update > ArmVirtPkg, MdeModulePkg, and OvmfPkg, and finally once the file is > consistent, proceed to merge 3/3. > > Changelog: > v1: > - Rebase to current Maintainers.txt. > - Fix typos and missed bits in Maintainers.txt. > - Get rid of the magic '' filename, let the single-char '*' >   wildcard resolve this (_using_ the magic '' filename in the >   script, but treating it as if it was a file in the top-level > directory). > - Add -l flag to script to look up which maintainers would be > returned for >   a given path (which need not exist). > rfc: > - Split patches up >   - one for new Maintainers.txt format (documentation and F: tags). >   - one for adding a new wilcards responsibility area for */Arm, > */AArch64 >   - one for the GetMaintainer.py script > - Reworked wildcard handling based on Laszlo's explanation >   - Trailing / covers everything under that directory >   - Trailing * does not cover subdirectories > - Added support for X: tag > - Added support for magic '' pathname > - Also prints mailing list addresses for matching L: tags > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Michael D Kinney > > Cc: Bob Feng > > Cc: Liming Gao > > Cc: Philippe Mathieu-Daude > > Cc: "Wu, Hao A" > > > Leif Lindholm (3): >   Maintainers.txt: update for filesystem area descriptions >   Maintainers.txt: add wildcard path association for Arm/AArch64 >   BaseTools: add GetMaintainer.py script > >  BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ >  Maintainers.txt                    |  54 ++++++++ >  2 files changed, 244 insertions(+) >  create mode 100644 BaseTools/Scripts/GetMaintainer.py > > -- > 2.20.1 >