From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web12.1185.1650396386940710642 for ; Tue, 19 Apr 2022 12:26:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=nvtPLfBF; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B8133320206E; Tue, 19 Apr 2022 15:26:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 19 Apr 2022 15:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1650396384; x= 1650482784; bh=pIlKUqZvWeMX1b+J05M/0v8InTvWwRvu640D3mfE1VA=; b=n vtPLfBF6BHVXnpO+1giJoOukAccfKx7CKiqEwpJYMQrtfUVBMAPNN9hhtYFyTur6 eiUM0BPoIr2fqVIxm5/DRKdC7vwgLKYJVaNIl48toFtnQQLoDla4Ld5x/myYdH5J C3/GIVs3hl7mGZ38fKBF32thw/xhiPSa1pSaEWLEHwa8RDCjr/dlPToTNSEEHk8U Q4xLuTX7KUK8Dncw0NRxJ/JBri9H0g7hVGXo4GJzo5QOfBGZwED9uLdcTxhr3IXO zytGpqdrYO9ufYgnjTTIKd7rel5IDEu1pR6nzr4klcOjvy84fzezZZxVcHHfdH5/ 8ZkqUzD+jDrAz4IXWVrIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650396384; x=1650482784; bh=pIlKUqZvWeMX1 b+J05M/0v8InTvWwRvu640D3mfE1VA=; b=GlUcQJ91x7ja5PdN/F7mPSXJXDX44 w2seaFKrEW95rpLRvZOr1PlIRbkKomLTxKC5meT73r6NyrOM8SURl7u1Ae7S+jbC 9LhCZ2oFUEgY3Rf6+cgaqcXqz4ChK02Ql0r+S73Kz5yMO1vFY7sr8AlVwnq2oqhR w1E9lOvxUa3r/rRtrC+lOCJ7KSHKx5Zt7gJ+L0i4E2zq3/5q24heyMeRmWzX5b8r EL/iUIOwihVyQ3wjkGDAYHiPpnb49PZ3uq2G9ITqvl4IFZ2ENh2dWR1BjqTrWqms 3tCGJuFLFuSUwTFML2WrH6BPiWhKMQT8jJ2N/wz7mdqtBB1nQlq19K9pg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpedugeejgeeludelgeejteehleeiudejhfdutdekfeekuefgieehteffjeei tdeiteenucffohhmrghinhepthhirghnohgtohhrvgdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihho rdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Apr 2022 15:26:22 -0400 (EDT) Message-ID: Date: Tue, 19 Apr 2022 13:26:21 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 7/8] OvmfPkg: Add VariableFlashInfoLib To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Min Xu , Peter Grehan , Sebastien Boeuf , Tom Lendacky References: <20220412162940.4978-1-mikuback@linux.microsoft.com> <20220412162940.4978-8-mikuback@linux.microsoft.com> From: "Rebecca Cran" In-Reply-To: <20220412162940.4978-8-mikuback@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran On 4/12/22 10:29, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > Adds an instance of VariableFlashInfoLib to the platform build as > it is a new library class introduced in MdeModulePkg. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Julien Grall > Cc: Min Xu > Cc: Peter Grehan > Cc: Rebecca Cran > Cc: Sebastien Boeuf > Cc: Tom Lendacky > Signed-off-by: Michael Kubacki > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > 9 files changed, 9 insertions(+) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index fcdc3efab204..3868c577fe39 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -195,6 +195,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > !if $(BUILD_SHELL) == TRUE > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index e1b6b8e15f36..3df49e54de8a 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -206,6 +206,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > # > # Network libraries > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc > index 20f3bc340807..19b84275eba3 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -216,6 +216,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > # > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > index 245155d41b30..f21a33ed6ba3 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > @@ -184,6 +184,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc > index 59580ccd4691..d8603f016a0c 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.dsc > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc > @@ -206,6 +206,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > # > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index e4218b01f0fc..c689d4707046 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -213,6 +213,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > # > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index a80cdaacb8bc..44c75639aa5d 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -217,6 +217,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > # > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index fb2899f8a1be..60e7e3724a6b 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -225,6 +225,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > # > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 7bd594c6e263..01d832323585 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -195,6 +195,7 @@ [LibraryClasses] > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > > #