public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Marcin Wojtas <mw@semihalf.com>, edk2-devel@lists.01.org
Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, jaz@semihalf.com,
	leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com
Subject: Re: [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid
Date: Mon, 16 Apr 2018 21:43:32 +0200	[thread overview]
Message-ID: <c0656049-34e7-7ae0-e1c0-7001bf7d378b@redhat.com> (raw)
In-Reply-To: <1523855353-9262-3-git-send-email-mw@semihalf.com>

On 04/16/18 07:09, Marcin Wojtas wrote:
> Recent changes in the EDK2 mainline resulted in breaking
> RTC functionality of Armada platforms.
> 
> The RealTimeClockLib instance calls gDS->SetMemorySpaceAttributes()
> in the LibRtcInitialize() public function. This DXE service depends
> on the CPU Arch Protocol. Add it to the depex.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf
> index 2f842e8..59c71c4 100644
> --- a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf
> +++ b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf
> @@ -25,7 +25,7 @@
>    FILE_GUID                      = fa81e889-045b-4c96-9093-742554fd0588
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = RealTimeClockLib
> +  LIBRARY_CLASS                  = RealTimeClockLib|DXE_RUNTIME_DRIVER
>  
>  [Sources.common]
>    RealTimeClockLib.c
> @@ -50,3 +50,6 @@
>  
>  [Pcd]
>    gMarvellTokenSpaceGuid.PcdRtcEnabled
> +
> +[Depex.common.DXE_RUNTIME_DRIVER]
> +  gEfiCpuArchProtocolGuid
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>


      parent reply	other threads:[~2018-04-16 19:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  5:09 [platforms PATCH 0/2] Armada7k8k adjustments to EDK2 Marcin Wojtas
2018-04-16  5:09 ` [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies Marcin Wojtas
2018-04-16  5:40   ` Ard Biesheuvel
2018-04-16  6:13     ` Marcin Wojtas
2018-04-16 19:41     ` Laszlo Ersek
2018-04-17  5:15       ` Marcin Wojtas
2018-04-17  5:32         ` Ard Biesheuvel
2018-04-17  6:04           ` Marcin Wojtas
2018-04-17  6:05             ` Ard Biesheuvel
2018-04-17  7:20         ` Laszlo Ersek
2018-04-16  5:09 ` [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid Marcin Wojtas
2018-04-16  5:40   ` Ard Biesheuvel
2018-04-16 19:43   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0656049-34e7-7ae0-e1c0-7001bf7d378b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox