From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 61EF72263DD6D for ; Mon, 16 Apr 2018 12:43:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BDC5402242D; Mon, 16 Apr 2018 19:43:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-213.rdu2.redhat.com [10.10.120.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6530F2026DFD; Mon, 16 Apr 2018 19:43:33 +0000 (UTC) To: Marcin Wojtas , edk2-devel@lists.01.org Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, jaz@semihalf.com, leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com References: <1523855353-9262-1-git-send-email-mw@semihalf.com> <1523855353-9262-3-git-send-email-mw@semihalf.com> From: Laszlo Ersek Message-ID: Date: Mon, 16 Apr 2018 21:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523855353-9262-3-git-send-email-mw@semihalf.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 19:43:34 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 19:43:34 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 19:43:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/16/18 07:09, Marcin Wojtas wrote: > Recent changes in the EDK2 mainline resulted in breaking > RTC functionality of Armada platforms. > > The RealTimeClockLib instance calls gDS->SetMemorySpaceAttributes() > in the LibRtcInitialize() public function. This DXE service depends > on the CPU Arch Protocol. Add it to the depex. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > index 2f842e8..59c71c4 100644 > --- a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > +++ b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > @@ -25,7 +25,7 @@ > FILE_GUID = fa81e889-045b-4c96-9093-742554fd0588 > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = RealTimeClockLib > + LIBRARY_CLASS = RealTimeClockLib|DXE_RUNTIME_DRIVER > > [Sources.common] > RealTimeClockLib.c > @@ -50,3 +50,6 @@ > > [Pcd] > gMarvellTokenSpaceGuid.PcdRtcEnabled > + > +[Depex.common.DXE_RUNTIME_DRIVER] > + gEfiCpuArchProtocolGuid > Acked-by: Laszlo Ersek