Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg V2: Adds generic FADT, HPET and WSMT table generators

["PierreGondois" <pierre.gondois@arm.com>]

Hello Abdul,
I think the FADT patch will change too much with the modifications currently
ongoing on the Arm/Arch common namespace objects. So it might not be worth
reviewing it for now.

The other patches will also have to be rebased/modified, but with less
modifications,

Regards,
Pierre

On 3/4/24 16:43, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> PR: https://github.com/tianocore/edk2/pull/5438
> 
> V2: delta changes
>    Addressed review comments
>    Adds ACPI HPET table to add HPET to ACPI namespace
> V1:
> Adds new space for ArchNameSpaceObjects.
> Adds generic FADT table generator.
> Adds generic HPET table generator.
> Adds generic WSMT table generator.
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> 
> Abdul Lateef Attar (4):
>    DynamicTablesPkg: Adds ACPI FADT Table generator
>    DynamicTablesPkg: Adds ACPI HPET Table generator
>    DynamicTablesPkg: Adds ACPI WSMT Table generator
>    DynamicTablesPkg: Adds ACPI SSDT HPET Table generator
> 
>   DynamicTablesPkg/DynamicTables.dsc.inc        |  16 +-
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml     |   7 +-
>   DynamicTablesPkg/Include/AcpiTableGenerator.h |   4 +
>   .../Include/ArchNameSpaceObjects.h            | 227 ++++++
>   .../Include/ConfigurationManagerObject.h      |   6 +
>   .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf  |  36 +
>   .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c |  39 +
>   .../Library/Acpi/AcpiFadtLib/FadtGenerator.c  | 747 ++++++++++++++++++
>   .../Library/Acpi/AcpiFadtLib/FadtUpdate.h     |  26 +
>   .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c |  32 +
>   .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf  |  35 +
>   .../Library/Acpi/AcpiHpetLib/HpetGenerator.c  | 216 +++++
>   .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf  |  36 +
>   .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c  | 266 +++++++
>   .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf  |  30 +
>   .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c  | 230 ++++++
>   16 files changed, 1950 insertions(+), 3 deletions(-)
>   create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenerator.c
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116631): https://edk2.groups.io/g/devel/message/116631
Mute This Topic: https://groups.io/mt/104724513/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-