From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 22A577803CF for ; Mon, 11 Mar 2024 14:15:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=r3KFbH0Nww/OGJJ1jXKp3U85QMNTfcHQoYIfccdzH7E=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710166554; v=1; b=B2bLY8rf6R9E8KSMblE1D93YrKCPRxYasnIUtWTNSRn5dMty+4/pdrw6D09Ck3Ho2HtZwjoV 8AnqvwEgZ5A3DMTjKpQcRk5+u2DXDvwb6PrwiPIcTCJe5zOUPk2a3sgc2/LZGVGC4DVCNKlhu6y BkkO8MikwS0Kr5RwdZ1c2irVPCCpHBAtqSEbEhOtJPdP2hF87Rv3gFnn0a4xNKmRO4dOm810LoY Ib5hGi+nTL180/6Uvg60SOYXafAIngLN5n61MYX3LYujVx+9+/p13Sc0KjwlI8WXC/Y/QhaHqyd vXRIaQvHi4O8uCN7f4oYQfp2tmmPEm4FrQeK2VVkOcwmA== X-Received: by 127.0.0.2 with SMTP id 2E7FYY7687511xNAMBePQ7Qv; Mon, 11 Mar 2024 07:15:54 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.63993.1710166553781869402 for ; Mon, 11 Mar 2024 07:15:54 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34405FEC; Mon, 11 Mar 2024 07:16:30 -0700 (PDT) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 955823F762; Mon, 11 Mar 2024 07:15:52 -0700 (PDT) Message-ID: Date: Mon, 11 Mar 2024 07:15:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg V2: Adds generic FADT, HPET and WSMT table generators To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Sami Mujawar References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bzeFnFgOcRYPvZtBHmm9PsOrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=B2bLY8rf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Abdul, I think the FADT patch will change too much with the modifications currentl= y ongoing on the Arm/Arch common namespace objects. So it might not be worth reviewing it for now. The other patches will also have to be rebased/modified, but with less modifications, Regards, Pierre On 3/4/24 16:43, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar >=20 > PR: https://github.com/tianocore/edk2/pull/5438 >=20 > V2: delta changes > Addressed review comments > Adds ACPI HPET table to add HPET to ACPI namespace > V1: > Adds new space for ArchNameSpaceObjects. > Adds generic FADT table generator. > Adds generic HPET table generator. > Adds generic WSMT table generator. >=20 > Cc: Sami Mujawar > Cc: Pierre Gondois > Cc: Abdul Lateef Attar >=20 >=20 > Abdul Lateef Attar (4): > DynamicTablesPkg: Adds ACPI FADT Table generator > DynamicTablesPkg: Adds ACPI HPET Table generator > DynamicTablesPkg: Adds ACPI WSMT Table generator > DynamicTablesPkg: Adds ACPI SSDT HPET Table generator >=20 > DynamicTablesPkg/DynamicTables.dsc.inc | 16 +- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 7 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 + > .../Include/ArchNameSpaceObjects.h | 227 ++++++ > .../Include/ConfigurationManagerObject.h | 6 + > .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf | 36 + > .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c | 39 + > .../Library/Acpi/AcpiFadtLib/FadtGenerator.c | 747 ++++++++++++++++++ > .../Library/Acpi/AcpiFadtLib/FadtUpdate.h | 26 + > .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c | 32 + > .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 35 + > .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 216 +++++ > .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf | 36 + > .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c | 266 +++++++ > .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf | 30 + > .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c | 230 ++++++ > 16 files changed, 1950 insertions(+), 3 deletions(-) > create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate= .h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUp= date.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSs= dtHpetLib.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHp= etGenerator.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenera= tor.c >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116631): https://edk2.groups.io/g/devel/message/116631 Mute This Topic: https://groups.io/mt/104724513/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-