From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7167B740040 for ; Thu, 2 May 2024 10:57:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XprF/UiPCWNUy2thj0GgCAn1q99roowg+H4cQSqCQzc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714647432; v=1; b=ADPWVTA7o9klQ1BNWe/TJTzcaNstGItIDXKLDO6Y3hp7htGsNIjC8rFsTzFDMw5yb/in5V8E jmH6ea/u81pBdmuXQcY0Qd0n6fCgxJ9FW4OPzqf51Xq3phwFKfhAe59P4mbfqde2+082ulqPN7x 6cnzNl2wLQ8zpYIPgVHD0bmkKd0oUmUm6eQ8hfFbEi6KCS4cnC+9j85vV6rGYR/tzl1jKWtcI9H 5tsiVOkKqE5muFPBFL0KwPbrk33iHJkKTg8VggqVCL3bQOC6bm8pW7HWsFgOO8slzfJtlLJUHo1 9ep6BFwQ7Hp7/4msl+IS3O/PuEUKJj8Q4MtULw6KmYGGg== X-Received: by 127.0.0.2 with SMTP id KLhEYY7687511xUkuD7CE5n7; Thu, 02 May 2024 03:57:12 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.10656.1714647431244877458 for ; Thu, 02 May 2024 03:57:11 -0700 X-Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 442AWpiX022452; Thu, 2 May 2024 10:57:07 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xuwxss667-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 10:57:06 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 442Av3lV024670 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 May 2024 10:57:03 GMT X-Received: from [10.111.142.244] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 2 May 2024 03:57:02 -0700 Message-ID: Date: Thu, 2 May 2024 11:57:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: , , , "rfc@edk2.groups.io" CC: "Andrew Fish (afish@apple.com)" References: <5116382f-a1cf-46fc-95a2-58c7f810765d@linux.microsoft.com> From: "Leif Lindholm" In-Reply-To: <5116382f-a1cf-46fc-95a2-58c7f810765d@linux.microsoft.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: wMf6GjEyBbGdMEsEuD--XchDugt8ivcg X-Proofpoint-GUID: wMf6GjEyBbGdMEsEuD--XchDugt8ivcg Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 03:57:11 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GAs5ACBD5vIoCfLBoJgP0Hoix7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ADPWVTA7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-05-02 04:08, Michael Kubacki wrote: > Thank you for this proposal. We've been anticipating this change for=20 > years and are excited to help support it. >=20 > Here's some items we'd like to raise for feedback that we could help=20 > implement. Many could likely be done in time for the transition. >=20 > 1. Automate reviewers - We've discussed CODEOWNERS in the past. However,= =20 > a simpler approach (in maintaining/syncing less files) would be to use=20 > Maintainers.txt directly with a GitHub workflow since the file already=20 > contains GitHub IDs. That would be ideal. I know Mike worked on autogenerating CODEOWNERS=20 from Maintainers.txt, but ultimately the latter supports more flexible=20 use of wildcards (things like */AArch64/ currently requires reconciling=20 against the repo contents). > 2. Make PR completion contingent on a GitHub review from at least one=20 > package maintainer/reviewer for each package in the PR. Yes. > 3. Dependabot is already used today to automatically create PRs when=20 > dependencies like pip modules have updates. To allow this to more=20 > effectively keep dependencies up-to-date, allow dependabot PRs to be=20 > completed (after normal acceptance criteria like CI and review=20 > requirements) without a separate human creating a duplicate PR. I am not sure what this means in practice :) This doesn't sound like one we need to worry about before switchover though= . > 4. Potentially warn users (with an automated comment on the PR) if they= =20 > add a push label to a PR that is less than 24 hours old. That sounds good. Is there any way to prevent force-pushes within 24h of previous push? That would make setting up a transitional review-scraper less lossy. > 5. Leave reminder comments on PRs with absolutely no activity after some= =20 > agreed upon time so reviewers are notified to review the PR without the= =20 > submitter having to watch it and send notifications. Yes. But should take priority below 1, 2, and 4. Unless you have a=20 pre-cooked thing to drop in of course. > 6. Leave reminder comments on PRs that meet all requirements to be=20 > completed (all reviews accounted for and status checks pass) but are=20 > still open so those on the PR are notified to complete it without the=20 > submitter having to manually watch and send reminders. Not a response to this, but triggered by reading this: Is there any way to approve changes within a PR on a commit by commit basis= ? > 7. We are happy to help with process documentation. Always appreciated,thanks. Regards, Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118506): https://edk2.groups.io/g/devel/message/118506 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-