From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.14163.1605133293065785097
 for <devel@edk2.groups.io>;
 Wed, 11 Nov 2020 14:21:33 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eP337JRe;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1605133292;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Fz90EB9tTEggdiX2Ius0I+lSfdxduteJ0iuQKDcLi2I=;
	b=eP337JRewMXqFa9kBqwchZFEealP5NgKmlqCyf/sCU5HScxnlFPQ0B7ZleoyI9+Co0Buba
	nKnFCNdjI3vTzTq45LZgohmANqNU9mYr1atxfOEC9uviI0jzi8Wg2wjpDJaaTlj4L86XJR
	Lpc3P9kdcvfpXOdIp9gdj0pXgfGtqkA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-339-mueqroBuPw61TalNrgSeww-1; Wed, 11 Nov 2020 17:21:28 -0500
X-MC-Unique: mueqroBuPw61TalNrgSeww-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37FE51006CAB;
	Wed, 11 Nov 2020 22:21:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-85.ams2.redhat.com [10.36.113.85])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D7EEB177F9;
	Wed, 11 Nov 2020 22:21:25 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH V3 03/12] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
To: devel@edk2.groups.io, zhichao.gao@intel.com
Cc: Jiewen Yao <jiewen.yao@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
 Xiaoyu Lu <xiaoyux.lu@intel.com>, Guomin Jiang <guomin.jiang@intel.com>
References: <20201110173651.54036-1-zhichao.gao@intel.com>
 <20201110173651.54036-4-zhichao.gao@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <c09b51a7-a309-9164-2e04-b4e2250b3d89@redhat.com>
Date: Wed, 11 Nov 2020 23:21:24 +0100
MIME-Version: 1.0
In-Reply-To: <20201110173651.54036-4-zhichao.gao@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/10/20 18:36, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021
> 
> CRYPTO_SERVICES PACKAGES and ALL config would enable MD5
> function. So explicitly enable MD5 while CRYPTO_SERVICES
> are set PACKAGES and ALL.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> ---
>  CryptoPkg/CryptoPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 7e51f6fac5..8dac4b1614 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -308,3 +308,6 @@
>  
>  [BuildOptions]
>    *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> +!if $(CRYPTO_SERVICES) IN "PACKAGE ALL"
> +  *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES
> +!endif
> 

This does not take into consideration that different toolchain families
require different spelling for "-D" vs. "/D". I suggest using the
toolchain family prefixes, such as "GCC:", "INTEL:", "MSFT:", "RVCT:".

Thanks
Laszlo