From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.dell-outbound.iphmx.com (esa4.dell-outbound.iphmx.com [68.232.149.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE03782137 for ; Fri, 17 Feb 2017 09:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1487352982; x=1518888982; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zGbTFlHS+++5VS6YVirru31SctUxJF0rjJUqr+mnC5g=; b=WzbtymK9IUE8lKoH3yW31svlTzk5ljFlSXDbQO0WiCUygQfSmWWIAklk YVfQlXOdjglbqWDE2zuimr0NE11loJtBAj8wy6LL55SFIcyTnGMHICV58 +8N3kS35fg/7B5ZrRE/SYSRgAm1vJapkQTOgekHvBVsUomPWw03eBS+03 w=; Received: from esa6.dell-outbound2.iphmx.com ([68.232.154.99]) by esa4.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2017 11:36:22 -0600 From: Received: from ausc60ps301.us.dell.com ([143.166.148.206]) by esa6.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2017 23:36:21 +0600 X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.35,172,1484028000"; d="scan'208";a="940471436" To: CC: , , Thread-Topic: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage Thread-Index: AQHShwz6TQunOBWyxEGGLjjxZm7yh6FpnqeAgAABMwCAAW/5AIAC5UwA//+CfUCAAAGecA== Date: Fri, 17 Feb 2017 17:35:57 +0000 Message-ID: References: <62a8491631d9dbde89d160ab213d3a16a2e76534.1487107403.git.jeff.westfahl@ni.com> <66fef1ec77c84e188120b733da3d00a9@ausx13mps335.AMER.DELL.COM> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titusconfig: No Restrictions 04051212 x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvIiwiaWQiOiI4NzE5MzljMC1iOTBiLTRhN2EtYTJhMi1hNjFhZTZiOWE2ZDAiLCJwcm9wcyI6W3sibiI6IkNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJObyBSZXN0cmljdGlvbnMifV19LHsibiI6IlN1YmxhYmVscyIsInZhbHMiOltdfSx7Im4iOiJFeHRlcm5hbENvcnJlc3BvbmRlbmNlIiwidmFscyI6W119XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTYuMi4xMS4wIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijg3UFdZemdBMytxK1ZRQnEwazQzTkd4N2pZbE5rT0pQWXUwQTlPYnpwXC9vPSJ9 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.210.125.233] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 17:36:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My point was that printing one byte of the data as hex is not much better (= as far as avoiding the crash is concerned) than simply not printing the data at al= l. If we are just trying to avoid the crash, printing nothing is even simpler. If the correct representation is hex bytes, fine; but why print only 1 of t= hem and not all of them? -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Cars= ey, Jaben Sent: Friday, February 17, 2017 11:28 AM To: Jeff Westfahl Cc: Ni, Ruiyu ; Carsey, Jaben ;= edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format speci= fier for LoadedImage I was reading the email. I was also waiting and making sure there was cons= ensus since I didn't have a strong opinion. I will let Ray check also, but= I think the fix is good. Reviewed-by: Jaben Carsey > -----Original Message----- > From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] > Sent: Friday, February 17, 2017 8:55 AM > To: Jeff Westfahl > Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Ni, > Ruiyu > Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > specifier for LoadedImage > Importance: High >=20 > Jaben, Ruiyu, >=20 > Sorry, I forgot to cc you as the ShellPkg maintainers when I submitted > this patch. >=20 > Regards, > Jeff Westfahl >=20 > On Wed, 15 Feb 2017, Jeff Westfahl wrote: >=20 > > Jim, > > > > I agree that those are good ideas. However, such an implementation woul= d > > still crash on a BIOS built against the EDK II before commit 891d844. I= think > > it might be best to resolve the crash with the simple patch I have made= , > and > > defer your suggestions for now. > > > > Regards, > > Jeff > > > > On Tue, 14 Feb 2017, Jim.Dailey@dell.com wrote: > > > >> Please disregard the earlier "Confidential" text. The stupid plug-in t= hat > >> adds this > >> does not show the text in the mail when it is composed in text mode, s= o I > >> often > >> forget to turn this "feature" off when posting. Sorry. > >> > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >> Dailey, Jim > >> Sent: Tuesday, February 14, 2017 4:40 PM > >> To: jeff.westfahl@ni.com; edk2-devel@lists.01.org > >> Subject: Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > >> specifier for LoadedImage > >> > >> Jeff, > >> > >> Perhaps a better approach is to print *all* the LoadOptions data as he= x > >> bytes? > >> > >> In addition, one might first analyze the LoadOptions data, and, when > >> apropos, > >> print obvious strings as strings? > >> > >> Regards, > >> Jim > >> > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jeff > >> Westfahl > >> Sent: Tuesday, February 14, 2017 3:54 PM > >> To: edk2-devel@lists.01.org > >> Subject: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format > specifier > >> for LoadedImage > >> > >> The format specifier for the LoadOptions field of the LoadedImage > protocol > >> is "%s". However, the data in LoadOptions is often generic binary data= . A > >> format specifier of "%x" is more appropriate for this field. > >> > >> Using "dh -v" with format specifier "%s" on BIOS images based on EDK I= I > >> source before commit 891d844 can cause a crash. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Jeff Westfahl > >> --- > >> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > >> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > >> index 0d51627c5f..273a4201bc 100644 > >> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > >> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > >> @@ -354,7 +354,7 @@ > >> " DeviceHandle..= : > >> %%H%x%%N\r\n" > >> " FilePath......= : > >> %%H%x%%N\r\n" > >> " OptionsSize...= : > >> %%H%x%%N\r\n" > >> - " LoadOptions..= .: > >> %%H%s%%N\r\n" > >> + " LoadOptions..= .: > >> %%H%x%%N\r\n" > >> " ImageBase.....= : > >> %%H%x%%N\r\n" > >> " ImageSize.....= : > >> %%H%Lx%%N\r\n" > >> " CodeType......= : > >> %%H%s%%N\r\n" > >> -- > >> 2.11.0.windows.3 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > >> > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel