From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 08 Jul 2019 10:02:34 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFBAAC070152; Mon, 8 Jul 2019 17:02:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-3.ams2.redhat.com [10.36.117.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFE1859471; Mon, 8 Jul 2019 17:02:18 +0000 (UTC) Subject: Re: [Patch v4 0/2] Enable new MM MP protocol To: Eric Dong , devel@edk2.groups.io Cc: Ray Ni References: <20190708140130.10632-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 8 Jul 2019 19:02:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190708140130.10632-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 08 Jul 2019 17:02:33 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Eric, On 07/08/19 16:01, Eric Dong wrote: > V4 changes: > 1. Use link list to save the used tokens. > > v3 changes: > 1. Fix Token clean up too early caused CheckProcedure return error. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1937 > > PI spec added a new protocol named MM MP protocol. This protocol allows for better remote queuing of execution of procedures on an AP. > This extends the existing procedures to allow: > 1. A function to be called in blocking and non-blocking manner explicitly 2. Allow broadcasts. > 3. Allow execution of a procedure when a processor powers up. > > This patch serial enable this new protocol. > > Cc: Ray Ni > Cc: Laszlo Ersek I'll try to regression-test this version after Ray is OK with it, from a review perspective. Thanks Laszlo > Eric Dong (2): > MdePkg: Add new MM MP Protocol definition. > UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol. > > MdePkg/Include/Pi/PiMultiPhase.h | 16 + > MdePkg/Include/Protocol/MmMp.h | 333 +++++++++++ > MdePkg/MdePkg.dec | 3 + > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 558 ++++++++++++++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 16 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 175 +++++- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 3 + > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c | 376 +++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 286 ++++++++++ > 9 files changed, 1744 insertions(+), 22 deletions(-) > create mode 100644 MdePkg/Include/Protocol/MmMp.h > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h >