From: rebecca@bsdio.com
To: devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"Fan, ZhijuX" <zhijux.fan@intel.com>,
Max Knutsen <maknutse@microsoft.com>,
Philippe Mathieu-Daude <philmd@redhat.com>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message
Date: Fri, 2 Aug 2019 15:32:12 -0600 [thread overview]
Message-ID: <c0beb6fc-2573-9151-cf93-b0fb021dc698@bsdio.com> (raw)
In-Reply-To: <20190802095506.GS22656@bivouac.eciton.net>
On 2019-08-02 03:55, Leif Lindholm wrote:
> One change I would like to see enacted *immediately* is that *any*
> imports from other open source projects state the repository and the
> commit hash that it originated from. In the commit message - and where
> BZs are referenced in the message, also copied into the BZ.
Could we perhaps at _least_ run a tool like pyflakes? That trivially
finds the error:
bcran@photon:~/workspace/edk2/BaseTools/Source/Python/Trim % pyflakes
Trim.py
Trim.py:181:12: invalid syntax
expect:
^
--
Rebecca Cran
next prev parent reply other threads:[~2019-08-02 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:02 [PATCH V2] BaseTools:Add extra debugging message Fan, ZhijuX
2019-07-25 11:04 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-26 6:43 ` Liming Gao
2019-08-01 12:19 ` Bob Feng
2019-08-01 12:57 ` Liming Gao
2019-08-02 9:55 ` Microsoft imports - was " Leif Lindholm
2019-08-02 10:06 ` Philippe Mathieu-Daudé
2019-08-02 21:32 ` rebecca [this message]
2019-08-07 11:19 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0beb6fc-2573-9151-cf93-b0fb021dc698@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox