From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web12.247.1606261377960196875 for ; Tue, 24 Nov 2020 15:42:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=ToCWYEW3; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AONX9eo112278; Tue, 24 Nov 2020 18:42:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=D72k5AqBneX4EQXx1wczeFqBJrZYnaGLNxGgCk1be7Q=; b=ToCWYEW3LQFMfH84E2GoI7YFmhI7RDBEHyseREb4YQmyKnzoUnrF6ulSW+QUsVV7Yqvf KTRX0z/JH2D0C4vBGAJH8+iCizpCNG4G5eMya0jLGfsXwb1PdtdWbEy15iHrpiEnxkG3 Ez2dplcB9OIJU2hCVmTSSR+MXLN9mNNyJ4A1iJrXKgmHLDTCQu5KLuRw8xvOudeb2gO6 pmM10JfuZPyau3I/CIWigsMRzPsD7HuE7w9+7VtzSrcss3AOuW7BwnwxEr5J7SqfHy+1 kNQO3fXnP/CyXZAUbfXSk69mGD7+vuLzN6QkSATsguQTwYBvsTZTxdR2EweZDvK62jZ8 lg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34yghsnf8p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 18:42:55 -0500 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AONXGcj113510; Tue, 24 Nov 2020 18:42:55 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 34yghsnf88-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 18:42:55 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AONbW1S015250; Tue, 24 Nov 2020 23:42:54 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 34xth9a96y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 23:42:54 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AONgpXp15401624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Nov 2020 23:42:51 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2A2E47805C; Tue, 24 Nov 2020 23:42:51 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 083437805F; Tue, 24 Nov 2020 23:42:48 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.194.234]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 24 Nov 2020 23:42:48 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Laszlo Ersek , devel@edk2.groups.io Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Tue, 24 Nov 2020 15:42:47 -0800 In-Reply-To: <1c871b56-f459-5ac4-3b8d-a55d978eac06@redhat.com> References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-3-jejb@linux.ibm.com> <28e99174-79b3-e805-b977-5fed0071a702@redhat.com> <06b9425507ab8c1b35d377cf9bba155b0cc44147.camel@linux.ibm.com> <3b7899fa-fa52-7652-2d2a-d4ec67ece34d@redhat.com> <1c871b56-f459-5ac4-3b8d-a55d978eac06@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-24_10:2020-11-24,2020-11-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240135 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2020-11-25 at 00:22 +0100, Laszlo Ersek wrote: > On 11/24/20 17:22, James Bottomley wrote: > > On Tue, 2020-11-24 at 16:58 +0100, Laszlo Ersek wrote: > > > On 11/24/20 15:54, Laszlo Ersek wrote: > > [...] > > > Perhaps I can make that recommendation / request more detailed > > > too: > > > > > > > > > * drop: > > > > > > - UefiRuntimeServicesTableLib: no use of "gRT" > > > > > > - ReportStatusCodeLib: commit 0a0566d5edad is not relevant, > > > because > > > we justifiedly removed TryRunningQemuKernel() > > > > > > - XenPlatformLib: as discussed before; substitute FALSE for each > > > XenDetected() call, and compress the resultant code > > > > All dropped. > > > > > * keep: > > > > > > - BaseLib: for CpuDeadLoop() > > > > > > - MemoryAllocationLib: for FreePool() > > > > > > - UefiBootServicesTableLib: for gBS->xxx() > > > > > > - BaseMemoryLib: for CompareMem() > > > > > > - DebugLib: for DEBUG() and ASSERT() > > > > > > - PcdLib: for PcdGet16 (PcdOvmfHostBridgePciDevId) > > > > > > - UefiBootManagerLib: for APIs central to the functionality of > > > PlatformBootManagerLibGrub > > > > > > - BootLogoLib: for BootLogoEnableLogo() > > > > > > - DevicePathLib: for a bunch of device path manipulation > > > > > > - PciLib: mainly for the functions called in > > > PciAcpiInitialization() > > > > > > - UefiLib: for EfiEventGroupSignal() etc > > > > > > - PlatformBmPrintScLib: for PlatformBmPrintScRegisterHandler() -- > > > this is responsible for printing the boot option processing steps > > > to > > > the UEFI console > > > > > > - Tcg2PhysicalPresenceLib: for > > > Tcg2PhysicalItPresenceLibProcessRequest() -- we preserve TPM > > > support > > > > > > > > > Then leaving the trimming of [Packages] to the end makes sense -- > > > after trimming everything else, try to remove each package DEC in > > > isolation, and see if the lib instance continues to build. > > > > I can't seem to remove any packages. Even the source debug agent > > one > > is used by the uart devices. > > OK! Thanks for checking. > > > It seems I can get rid of PcdFSBClock > > > > and in the protocols section (with some header file removal) > > > > gEfiDecompressProtocolGuid > > gEfiS3SaveStateProtocolGuid > > Yes, I agree removing these is correct; they were also included in my > other email at ;. > > There are some others that should be possible to remove (pls. refer > to the rest of that email). Heh, well, I spoke too soon. Even though the OVMF this produces boots to grub and decrypts an encrypted volume, the kernel boot panics because of something missing in the runtime ... it looks like it's tripping over gRT->SetVariable, so I'm going to have to start putting some stuff back again ... James