From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 04:00:06 -0700 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 444B5368DA for ; Tue, 24 Sep 2019 11:00:05 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id t11so426498wro.10 for ; Tue, 24 Sep 2019 04:00:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8Xpr9WyF2UR19frfQFqV2/E081Byr3bwHUszV2bCKwo=; b=pzzWUzBesE3g+orpMDW85sp6lsCsgl9WDYsf0QQGbCvellASsmrtaoIpHvMUxFgXog 2TN6BYqgaCZoz/c2pYPhFsqGH4DoDTkl81WW9OkVPXqIfs3aUVqFEkWnq/YmA8/4oHM5 CvUWS+eVY5Q02wcDFUuqXtIx3U1nbEx98lLSP2esxklzQovVTcbnQN0f8oea5uXc1iGe le5N440q3A6obFSJ4HRPuSlv0/xUwA2Ig7erQBJ/3NOjpBN+xxQySK4MGEIpAWLR1G5p HIDziaMQD4/7L+4vGF3bkZQk9XoGGZPg+Pt0tAj4mvz7JBXQUtI1cuwer6d7A2/mSr89 3cfQ== X-Gm-Message-State: APjAAAVciy8sY4L0KuEyR9LjZWXBDiJ6eIaLlDqS512YsUTUpS/YF+CJ wlyO+Etz3NLw0+7uNkprAgl9ti1fQwEklJkXgq8AMXJ7rOO8VtgUrsIChugkoxi/MXFGz8NErHe i0DxEqgQq9MULOA== X-Received: by 2002:a7b:c404:: with SMTP id k4mr2054914wmi.90.1569322804007; Tue, 24 Sep 2019 04:00:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6AD+ZcXi71ZqVPJfflNmfufA1NTayV1JoPiLaWGBXqwsnf3c7ExO4pp9eaa+TT6WNDnfK+w== X-Received: by 2002:a7b:c404:: with SMTP id k4mr2054896wmi.90.1569322803834; Tue, 24 Sep 2019 04:00:03 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id n18sm1845037wmi.20.2019.09.24.04.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 04:00:03 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() To: devel@edk2.groups.io, lersek@redhat.com Cc: Jiaxin Wu , Siyuan Fu References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-19-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 24 Sep 2019 13:00:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-19-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). > NetLibGetMacAddress() only uses the return value ("SnpHandle") for a > NULL-check. Fix the type of "SnpHandle". > > This patch is a no-op. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- > > Notes: > lightly tested: MAC strings are displayed in UiApp > > NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > index 8e2f720666ea..a39c20be3d34 100644 > --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( > EFI_SIMPLE_NETWORK_MODE SnpModeData; > EFI_MANAGED_NETWORK_PROTOCOL *Mnp; > EFI_SERVICE_BINDING_PROTOCOL *MnpSb; > - EFI_HANDLE *SnpHandle; > + EFI_HANDLE SnpHandle; > EFI_HANDLE MnpChildHandle; > > ASSERT (MacAddress != NULL); > Since SnpHandle is only checked for being non-null, this change is indeed a no-op, else it would probably fixed some bug. Reviewed-by: Philippe Mathieu-Daude