public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Peter Grehan <grehan@freebsd.org>
Subject: Re: [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue
Date: Tue, 9 Nov 2021 18:38:30 -0700	[thread overview]
Message-ID: <c0ff3c07-34bf-3b25-8d4a-3ee5df71eb90@bsdio.com> (raw)
In-Reply-To: <20211109045357.543-1-michael.d.kinney@intel.com>

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


On 11/8/21 9:53 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724
>
> Add typecast to fix build error with VS2019 X64 NOOPT converting
> a UINT64 value to UINT32 value.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> index d980e3fcb068..c23b90673328 100644
> --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c
> +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> @@ -191,7 +191,7 @@ MemMapInitialization (
>         ASSERT (PciExBarBase <= MAX_UINT32 - SIZE_256MB);
>         PciBase = (UINT32)(PciExBarBase + SIZE_256MB);
>       } else {
> -      PciBase = PcdGet64 (PcdPciMmio32Base);
> +      PciBase = (UINT32)PcdGet64 (PcdPciMmio32Base);
>         if (PciBase == 0)
>           PciBase = (TopOfLowRam < BASE_2GB) ? BASE_2GB : TopOfLowRam;
>       }


      parent reply	other threads:[~2021-11-10  1:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  4:53 [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue Michael D Kinney
2021-11-09  7:13 ` Peter Grehan
2021-11-10  1:38 ` Rebecca Cran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0ff3c07-34bf-3b25-8d4a-3ee5df71eb90@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox