* [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue @ 2021-11-09 4:53 Michael D Kinney 2021-11-09 7:13 ` Peter Grehan 2021-11-10 1:38 ` Rebecca Cran 0 siblings, 2 replies; 3+ messages in thread From: Michael D Kinney @ 2021-11-09 4:53 UTC (permalink / raw) To: devel; +Cc: Rebecca Cran, Peter Grehan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724 Add typecast to fix build error with VS2019 X64 NOOPT converting a UINT64 value to UINT32 value. Cc: Rebecca Cran <rebecca@bsdio.com> Cc: Peter Grehan <grehan@freebsd.org> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> --- OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c index d980e3fcb068..c23b90673328 100644 --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c @@ -191,7 +191,7 @@ MemMapInitialization ( ASSERT (PciExBarBase <= MAX_UINT32 - SIZE_256MB); PciBase = (UINT32)(PciExBarBase + SIZE_256MB); } else { - PciBase = PcdGet64 (PcdPciMmio32Base); + PciBase = (UINT32)PcdGet64 (PcdPciMmio32Base); if (PciBase == 0) PciBase = (TopOfLowRam < BASE_2GB) ? BASE_2GB : TopOfLowRam; } -- 2.32.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue 2021-11-09 4:53 [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue Michael D Kinney @ 2021-11-09 7:13 ` Peter Grehan 2021-11-10 1:38 ` Rebecca Cran 1 sibling, 0 replies; 3+ messages in thread From: Peter Grehan @ 2021-11-09 7:13 UTC (permalink / raw) To: Michael D Kinney, devel; +Cc: Rebecca Cran > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724 > > Add typecast to fix build error with VS2019 X64 NOOPT converting> a UINT64 value to UINT32 value.> > Cc: Rebecca Cran <rebecca@bsdio.com>> Cc: Peter Grehan <grehan@freebsd.org>> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Acked-by: Peter Grehan <grehan@freebsd.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue 2021-11-09 4:53 [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue Michael D Kinney 2021-11-09 7:13 ` Peter Grehan @ 2021-11-10 1:38 ` Rebecca Cran 1 sibling, 0 replies; 3+ messages in thread From: Rebecca Cran @ 2021-11-10 1:38 UTC (permalink / raw) To: Michael D Kinney, devel; +Cc: Peter Grehan Reviewed-by: Rebecca Cran <rebecca@bsdio.com> On 11/8/21 9:53 PM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724 > > Add typecast to fix build error with VS2019 X64 NOOPT converting > a UINT64 value to UINT32 value. > > Cc: Rebecca Cran <rebecca@bsdio.com> > Cc: Peter Grehan <grehan@freebsd.org> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> > --- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c > index d980e3fcb068..c23b90673328 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c > @@ -191,7 +191,7 @@ MemMapInitialization ( > ASSERT (PciExBarBase <= MAX_UINT32 - SIZE_256MB); > PciBase = (UINT32)(PciExBarBase + SIZE_256MB); > } else { > - PciBase = PcdGet64 (PcdPciMmio32Base); > + PciBase = (UINT32)PcdGet64 (PcdPciMmio32Base); > if (PciBase == 0) > PciBase = (TopOfLowRam < BASE_2GB) ? BASE_2GB : TopOfLowRam; > } ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-10 1:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-11-09 4:53 [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue Michael D Kinney 2021-11-09 7:13 ` Peter Grehan 2021-11-10 1:38 ` Rebecca Cran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox