public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Eric Jin <eric.jin@intel.com>, edk2-devel@lists.01.org
Subject: Re: [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.
Date: Fri, 12 Oct 2018 08:56:10 +0100	[thread overview]
Message-ID: <c1098b6d-69e0-0dfb-06f7-688188e0d773@arm.com> (raw)
In-Reply-To: <20181011022924.14052-1-eric.jin@intel.com>

Since this was already present in 
https://github.com/UEFI/UEFI-SCT/commit/c2a650dd1c39ed653f8f94e436def51b5edf6c71and 
it is just migrating over to new repository.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

if commit msg is changed to uefi-sct/SctPkg instead of uefi-sct\SctPkg, 
while pushing upstream.


On 10/11/2018 03:29 AM, Eric Jin wrote:
> GetNextSlot() returns the slot number on the controller,
> but the SD card specified by Slot may not exist on the SD controller.
>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>   .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> index 6b001cd..05005a0 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> @@ -1,7 +1,7 @@
>   /** @file
>   
>     Copyright 2017 Unified EFI, Inc.<BR>
> -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
>   
>     This program and the accompanying materials
>     are licensed and made available under the terms and conditions of the BSD License
> @@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
>                        (UINTN)DevicePath->SubType,
>                        (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
>                        );
> -    } else if (Status == EFI_OUT_OF_RESOURCES)
> +    } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
>         AssertionType = EFI_TEST_ASSERTION_WARNING;
>       else
>         AssertionType = EFI_TEST_ASSERTION_FAILED;



      reply	other threads:[~2018-10-12  7:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  2:29 [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot Eric Jin
2018-10-12  7:56 ` Supreeth Venkatesh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1098b6d-69e0-0dfb-06f7-688188e0d773@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox