From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id CD77B21168211 for ; Fri, 12 Oct 2018 00:56:12 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 371B5F; Fri, 12 Oct 2018 00:56:12 -0700 (PDT) Received: from [10.6.43.238] (bc-c3-3-14.eu.iaas.arm.com [10.6.43.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F23C3F5B7; Fri, 12 Oct 2018 00:56:11 -0700 (PDT) To: Eric Jin , edk2-devel@lists.01.org References: <20181011022924.14052-1-eric.jin@intel.com> From: Supreeth Venkatesh Message-ID: Date: Fri, 12 Oct 2018 08:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181011022924.14052-1-eric.jin@intel.com> X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 07:56:13 -0000 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Since this was already present in https://github.com/UEFI/UEFI-SCT/commit/c2a650dd1c39ed653f8f94e436def51b5edf6c71and it is just migrating over to new repository. Reviewed-by: Supreeth Venkatesh if commit msg is changed to uefi-sct/SctPkg instead of uefi-sct\SctPkg, while pushing upstream. On 10/11/2018 03:29 AM, Eric Jin wrote: > GetNextSlot() returns the slot number on the controller, > but the SD card specified by Slot may not exist on the SD controller. > > Cc: Supreeth Venkatesh > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Jin > --- > .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c > index 6b001cd..05005a0 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c > @@ -1,7 +1,7 @@ > /** @file > > Copyright 2017 Unified EFI, Inc.
> - Copyright (c) 2017, Intel Corporation. All rights reserved.
> + Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > @@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest ( > (UINTN)DevicePath->SubType, > (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8) > ); > - } else if (Status == EFI_OUT_OF_RESOURCES) > + } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND)) > AssertionType = EFI_TEST_ASSERTION_WARNING; > else > AssertionType = EFI_TEST_ASSERTION_FAILED;