[PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.

[PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.

[Eric Jin]

GetNextSlot() returns the slot number on the controller,
but the SD card specified by Slot may not exist on the SD controller.

Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin <eric.jin@intel.com>
---
 .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
index 6b001cd..05005a0 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
@@ -1,7 +1,7 @@
 /** @file
 
   Copyright 2017 Unified EFI, Inc.<BR>
-  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
                      (UINTN)DevicePath->SubType,
                      (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
                      );
-    } else if (Status == EFI_OUT_OF_RESOURCES)
+    } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
       AssertionType = EFI_TEST_ASSERTION_WARNING;
     else
       AssertionType = EFI_TEST_ASSERTION_FAILED;
-- 
2.9.0.windows.1

Re: [PATCH][edk2-test]uefi-sct\SctPkg: Consider the corner case that no device is on the slot.

[Supreeth Venkatesh]

Since this was already present in 
https://github.com/UEFI/UEFI-SCT/commit/c2a650dd1c39ed653f8f94e436def51b5edf6c71and 
it is just migrating over to new repository.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

if commit msg is changed to uefi-sct/SctPkg instead of uefi-sct\SctPkg, 
while pushing upstream.


On 10/11/2018 03:29 AM, Eric Jin wrote:
> GetNextSlot() returns the slot number on the controller,
> but the SD card specified by Slot may not exist on the SD controller.
>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin <eric.jin@intel.com>
> ---
>   .../Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> index 6b001cd..05005a0 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SDMMCPassThru/BlackBoxTest/SDMMCPassThruBBTestFunction.c
> @@ -1,7 +1,7 @@
>   /** @file
>   
>     Copyright 2017 Unified EFI, Inc.<BR>
> -  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
>   
>     This program and the accompanying materials
>     are licensed and made available under the terms and conditions of the BSD License
> @@ -416,7 +416,7 @@ BBTestBuildDevicePathFunctionTest (
>                        (UINTN)DevicePath->SubType,
>                        (UINTN)(DevicePath->Length[0] | DevicePath->Length[1] << 8)
>                        );
> -    } else if (Status == EFI_OUT_OF_RESOURCES)
> +    } else if ((Status == EFI_OUT_OF_RESOURCES) || (Status == EFI_NOT_FOUND))
>         AssertionType = EFI_TEST_ASSERTION_WARNING;
>       else
>         AssertionType = EFI_TEST_ASSERTION_FAILED;