* [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs
@ 2018-10-29 10:48 Tomas Pilar (tpilar)
2018-10-29 12:05 ` Zhu, Yonghong
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Pilar (tpilar) @ 2018-10-29 10:48 UTC (permalink / raw)
To: edk2-devel@lists.01.org
The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following
the Device List introduced in the PCI Spec rev 3.0. This commit documents the
amended syntax.
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
3_edk_ii_fdf_file_format/311_pci_optionrom_section.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
index 08f50e7..8267fbb 100644
--- a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
+++ b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
@@ -58,7 +58,7 @@ Conditional statements may be used anywhere within this section.
<Overrides> ::= <MTS> "{" <EOL>
[<TS> "PCI_VENDOR_ID" <Eq> <UINT16> <EOL>]
[<TS> "PCI_CLASS_CODE" <Eq> <UINT8> <EOL>]
- [<TS> "PCI_DEVICE_ID" <Eq> <UINT16> <EOL>]
+ [<TS> "PCI_DEVICE_ID" <Eq> <UINT16> [<MTS> <UINT16>]* <EOL>]
[<TS> "PCI_REVISION" <Eq> <UINT8> <EOL>]
[<TS> "PCI_COMPRESS" <Eq> <TrueFalse> <EOL>]
<TS> "}" <EOL>
@@ -108,6 +108,7 @@ for the .efi extension in the ENBF above.
[OptionRom.AtapiPassThru]
INF USE = IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf {
PCI_REVISION = 0x0020
+ PCI_DEVICE_ID = 0x0A03 0x0B03
}
INF USE = EBC OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
```
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs
2018-10-29 10:48 [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs Tomas Pilar (tpilar)
@ 2018-10-29 12:05 ` Zhu, Yonghong
0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-10-29 12:05 UTC (permalink / raw)
To: Tomas Pilar (tpilar), edk2-devel@lists.01.org
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tomas Pilar (tpilar)
Sent: Monday, October 29, 2018 6:48 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs
The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following the Device List introduced in the PCI Spec rev 3.0. This commit documents the amended syntax.
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
3_edk_ii_fdf_file_format/311_pci_optionrom_section.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
index 08f50e7..8267fbb 100644
--- a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
+++ b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
@@ -58,7 +58,7 @@ Conditional statements may be used anywhere within this section.
<Overrides> ::= <MTS> "{" <EOL>
[<TS> "PCI_VENDOR_ID" <Eq> <UINT16> <EOL>]
[<TS> "PCI_CLASS_CODE" <Eq> <UINT8> <EOL>]
- [<TS> "PCI_DEVICE_ID" <Eq> <UINT16> <EOL>]
+ [<TS> "PCI_DEVICE_ID" <Eq> <UINT16> [<MTS>
+ <UINT16>]* <EOL>]
[<TS> "PCI_REVISION" <Eq> <UINT8> <EOL>]
[<TS> "PCI_COMPRESS" <Eq> <TrueFalse> <EOL>]
<TS> "}" <EOL>
@@ -108,6 +108,7 @@ for the .efi extension in the ENBF above.
[OptionRom.AtapiPassThru]
INF USE = IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf {
PCI_REVISION = 0x0020
+ PCI_DEVICE_ID = 0x0A03 0x0B03
}
INF USE = EBC OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
```
--
2.17.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-29 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-29 10:48 [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs Tomas Pilar (tpilar)
2018-10-29 12:05 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox