From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=67.231.154.164; helo=dispatch1-us1.ppe-hosted.com; envelope-from=tpilar@solarflare.com; receiver=edk2-devel@lists.01.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DBCE921184AD9 for ; Mon, 29 Oct 2018 03:48:16 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 74C3C140066 for ; Mon, 29 Oct 2018 10:48:15 +0000 (UTC) Received: from tp-desktop.uk.solarflarecom.com (10.17.20.51) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 29 Oct 2018 03:48:12 -0700 From: "Tomas Pilar (tpilar)" To: "edk2-devel@lists.01.org" Message-ID: Date: Mon, 29 Oct 2018 10:48:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 X-Originating-IP: [10.17.20.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24186.005 X-TM-AS-Result: No-0.653300-4.000000-10 X-TMASE-MatchedRID: xtgTkG+GaOcpz7oBrDd6eQXysW33GYMp0vNkFv6xUCPjud2x7TPVt1O4 BD7nLMxnrUhQzMxACbq+3xvFB5M1lnuLfgSBmtT0aK+MsTwM+1kt0t+aIVLt+8pj/9aYiP+hhJD aXmsbdjTi8zVgXoAltlwtzewu2M63jaPj0W1qn0SrvtPKKgnMGK7bqmmg2xHdZMkUGceK7e/Dla X0thMrZXRnXgXUbwycNGYDoFpPiJRJS62SkOIfAhKdowmHmvwNa21Y8oG2+asm5S0VX/DixVod/ W7q+NhGWldZy+lusqMycTwl+NvDMn5MMVtQ/Sk1ol4UnYQOlTVWXGvUUmKP2w== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.653300-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24186.005 X-MDID: 1540810096-4VFPOULNbtii Subject: [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 X-List-Received-Date: Mon, 29 Oct 2018 10:48:17 -0000 Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following the Device List introduced in the PCI Spec rev 3.0. This commit documents the amended syntax. Signed-off-by: Tomas Pilar Contributed-under: TianoCore Contribution Agreement 1.1 --- 3_edk_ii_fdf_file_format/311_pci_optionrom_section.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md index 08f50e7..8267fbb 100644 --- a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md +++ b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md @@ -58,7 +58,7 @@ Conditional statements may be used anywhere within this section. ::= "{" [ "PCI_VENDOR_ID" ] [ "PCI_CLASS_CODE" ] - [ "PCI_DEVICE_ID" ] + [ "PCI_DEVICE_ID" [ ]* ] [ "PCI_REVISION" ] [ "PCI_COMPRESS" ] "}" @@ -108,6 +108,7 @@ for the .efi extension in the ENBF above. [OptionRom.AtapiPassThru] INF USE = IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf { PCI_REVISION = 0x0020 + PCI_DEVICE_ID = 0x0A03 0x0B03 } INF USE = EBC OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf ``` -- 2.17.2