[PATCH v1 1/1] BaseTools: remove unused code

[PATCH v1 1/1] BaseTools: remove unused code

[Jaben Carsey]

the if statment just has pass statement.
invert if condition and just use do the else work.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Workspace/InfBuildData.py | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py
index 29e68aeb3bf3..44eaebf62e50 100644
--- a/BaseTools/Source/Python/Workspace/InfBuildData.py
+++ b/BaseTools/Source/Python/Workspace/InfBuildData.py
@@ -370,11 +370,7 @@ class InfBuildData(ModuleBuildClassObject):
                     self._Sources.append(File)
                 else:
                     ToolList = self._NMAKE_FLAG_PATTERN_.findall(Name)
-                    if len(ToolList) == 0 or len(ToolList) != 1:
-                        pass
-#                        EdkLogger.warn("build", "Don't know how to do with macro [%s]" % Name,
-#                                       File=self.MetaFile, Line=LineNo)
-                    else:
+                    if len(ToolList) == 1:
                         if self._BuildOptions is None:
                             self._BuildOptions = OrderedDict()
 
-- 
2.16.2.windows.1

Re: [PATCH v1 1/1] BaseTools: remove unused code

[Zhu, Yonghong]

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Carsey, Jaben 
Sent: Friday, August 17, 2018 7:24 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH v1 1/1] BaseTools: remove unused code

the if statment just has pass statement.
invert if condition and just use do the else work.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Workspace/InfBuildData.py | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py
index 29e68aeb3bf3..44eaebf62e50 100644
--- a/BaseTools/Source/Python/Workspace/InfBuildData.py
+++ b/BaseTools/Source/Python/Workspace/InfBuildData.py
@@ -370,11 +370,7 @@ class InfBuildData(ModuleBuildClassObject):
                     self._Sources.append(File)
                 else:
                     ToolList = self._NMAKE_FLAG_PATTERN_.findall(Name)
-                    if len(ToolList) == 0 or len(ToolList) != 1:
-                        pass
-#                        EdkLogger.warn("build", "Don't know how to do with macro [%s]" % Name,
-#                                       File=self.MetaFile, Line=LineNo)
-                    else:
+                    if len(ToolList) == 1:
                         if self._BuildOptions is None:
                             self._BuildOptions = OrderedDict()
 
-- 
2.16.2.windows.1