From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8240221E2DA4F for ; Tue, 15 Aug 2017 17:34:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7570E796FF; Wed, 16 Aug 2017 00:37:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7570E796FF Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-68.phx2.redhat.com [10.3.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25B1367CF8; Wed, 16 Aug 2017 00:37:10 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-5-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: Date: Wed, 16 Aug 2017 02:37:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502710605-8058-5-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 16 Aug 2017 00:37:12 +0000 (UTC) Subject: Re: [PATCH v2 04/23] OvmfPkg/VirtioMmioDeviceLib: add missing IN and OUT decoration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 00:34:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/14/17 13:36, Brijesh Singh wrote: > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 28 ++++++++++---------- > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 28 ++++++++++---------- > 2 files changed, 28 insertions(+), 28 deletions(-) > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > index 4130dbc043df..bedd635e1a86 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > @@ -85,29 +85,29 @@ VirtioMmioGetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueSize > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueNotify > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueNotify > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ); > > EFI_STATUS > @@ -119,22 +119,22 @@ VirtioMmioSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetGuestFeatures ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT64 Features > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT64 Features > ); > > #endif // _VIRTIO_MMIO_DEVICE_INTERNAL_H_ > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > index 53c734f6b1af..9142d4a162c0 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > @@ -81,8 +81,8 @@ VirtioMmioGetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueSize > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -97,8 +97,8 @@ VirtioMmioSetQueueSize ( > EFI_STATUS > EFIAPI > VirtioMmioSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -113,8 +113,8 @@ VirtioMmioSetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueNotify > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueNotify > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -129,8 +129,8 @@ VirtioMmioSetQueueNotify ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -145,8 +145,8 @@ VirtioMmioSetQueueAlignment ( > EFI_STATUS > EFIAPI > VirtioMmioSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -165,8 +165,8 @@ VirtioMmioSetPageSize ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -197,8 +197,8 @@ VirtioMmioSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioMmioSetGuestFeatures ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT64 Features > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT64 Features > ) > { > VIRTIO_MMIO_DEVICE *Device; > Reviewed-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek Commit 22701a3d4dd1fd3eed385215d6e2dad0ad069b7f. Thanks Laszlo