From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CED081DD5 for ; Mon, 16 Jan 2017 11:47:15 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D6CE4A543; Mon, 16 Jan 2017 19:47:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-110.phx2.redhat.com [10.3.116.110]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0GJlEl4030397; Mon, 16 Jan 2017 14:47:15 -0500 To: Ard Biesheuvel , Bhupesh Sharma References: <1484579178-887-1-git-send-email-bhsharma@redhat.com> Cc: "edk2-devel@lists.01.org" , Bhupesh SHARMA From: Laszlo Ersek Message-ID: Date: Mon, 16 Jan 2017 20:47:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 16 Jan 2017 19:47:16 +0000 (UTC) Subject: Re: [PATCH 1/1] ArmVirtPkg/ArmVirtQemu: Install BGRT ACPI table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 19:47:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 01/16/17 18:08, Ard Biesheuvel wrote: > On 16 January 2017 at 15:06, Bhupesh Sharma wrote: >> While debugging OS for ACPI BGRT support (especially on VMs), >> it is very useful to have the EFI firmware to export the >> ACPI BGRT table. >> >> This patch tries to add this support in ArmVirtPkg. >> >> Cc: Ard Biesheuvel >> Cc: Laszlo Ersek >> Signed-off-by: Bhupesh Sharma >> Contributed-under: TianoCore Contribution Agreement 1.0 > > Reviewed-by: Ard Biesheuvel > > Pushed as 13a50a6fe1dc > > When booting in graphical mode, acpidump gives me > > BGRT @ 0x000000013BC90000 > 0000: 42 47 52 54 38 00 00 00 01 70 49 4E 54 45 4C 20 BGRT8....pINTEL > 0010: 45 44 4B 32 20 20 20 20 02 00 00 00 20 20 20 20 EDK2 .... > 0020: 13 00 00 01 01 00 01 00 00 30 FF FF 00 00 00 00 .........0...... > 0030: 2F 01 00 00 0F 01 00 00 /....... > > which looks close enough to me (I haven't attempted to decode the > contents to figure out whether they make sense or not) > > Thanks! Thank you, Bhupesh and Ard! The patch looks good to me as well. Laszlo > >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 0cae9968f4ea..8fe3c3816961 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -390,6 +390,7 @@ >> # >> # ACPI Support >> # >> + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { >> >> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> index a2e82b3179e8..cc5d12aaefea 100644 >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> @@ -145,6 +145,7 @@ READ_LOCK_STATUS = TRUE >> # ACPI Support >> # >> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf >> + INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf >> >> # >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index fe76c2263faa..aa40374745af 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -379,6 +379,7 @@ >> # >> # ACPI Support >> # >> + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { >> >> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> -- >> 2.7.4 >>