From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: Re: [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg
Date: Wed, 6 Jan 2021 17:23:46 +0100 [thread overview]
Message-ID: <c1482263-9b9e-c9d1-6919-56c093b6bb42@arm.com> (raw)
In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com>
On 12/16/20 6:21 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on the ArmPkg require modifications.
>
> The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1
>
> Pierre Gondois (25):
> ArmPkg: Format header to fix Ecc crash in ArmMmuLib
> ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib
> ArmPkg: Fix Ecc error 3002 in OpteeLib
> ArmPkg: Fix Ecc error 3002 in ArmMmuLib
> ArmPkg: Fix Ecc error 3002 in TimerDxe
> ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe
> ArmPkg: Fix Ecc error 3002 in CpuDxe
> ArmPkg: Fix Ecc error 3002 in SemihostFs
> ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib
> ArmPkg: Fix Ecc error 3001 in SemihostFs
> ArmPkg: Fix Ecc error 5005 in CpuDxe
> ArmPkg: Fix Ecc error 5005 in ArmExceptionLib
> ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib
> ArmPkg: Fix Ecc error 5007 in ArmScmiDxe
> ArmPkg: Fix Ecc error 5007 in CpuDxe
> ArmPkg: Fix Ecc error 5007 in TimerDxe
> ArmPkg: Fix Ecc error 5007 in SemihostFs
> ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib
> ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib
> ArmPkg: Fix Ecc error 5007 in ArmLib
> ArmPkg: Fix Ecc error 5007 in ArmMmuLib
> ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib
> ArmPkg: Fix Ecc error 5007 in SemihostLib
> ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib
> ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Merged as #1305 (with a few tweaks)
Thanks Pierre!
> ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 5 ++-
> ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 8 ++--
> ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 8 ++--
> ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 14 +++----
> ArmPkg/Drivers/CpuDxe/Exception.c | 8 ++--
> .../MmCommunicationDxe/MmCommunication.c | 4 +-
> ArmPkg/Drivers/TimerDxe/TimerDxe.c | 7 ++--
> ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 25 ++++++-----
> .../ArmCacheMaintenanceLib.c | 13 +++---
> .../ArmDisassemblerLib/ArmDisassembler.c | 11 ++++-
> .../Library/ArmExceptionLib/ArmExceptionLib.c | 5 ++-
> ArmPkg/Library/ArmLib/ArmLib.c | 20 +++------
> .../Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +-
> .../AArch64/ArmMmuPeiLibConstructor.c | 14 +++----
> .../Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 34 +++++++--------
> .../Library/CompilerIntrinsicsLib/memcmp_ms.c | 10 +++--
> ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c | 11 +++--
> .../Library/CompilerIntrinsicsLib/memcpy_ms.c | 11 +++--
> .../CompilerIntrinsicsLib/memmove_ms.c | 14 +++++--
> ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 8 +++-
> .../Library/CompilerIntrinsicsLib/memset_ms.c | 8 +++-
> .../Arm/DefaultExceptionHandler.c | 41 ++++++++++---------
> ArmPkg/Library/OpteeLib/Optee.c | 7 ++--
> .../SemiHostingSerialPortLib/SerialPortLib.c | 8 +++-
> ArmPkg/Library/SemihostLib/SemihostLib.c | 6 +--
> .../AArch64/ArmMmuStandaloneMmLib.c | 13 +++---
> 26 files changed, 182 insertions(+), 133 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2021-01-06 16:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 17:21 [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg PierreGondois
2020-12-16 17:21 ` [PATCH v1 01/25] ArmPkg: Format header to fix Ecc crash in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 02/25] ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 03/25] ArmPkg: Fix Ecc error 3002 in OpteeLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 04/25] ArmPkg: Fix Ecc error 3002 in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 05/25] ArmPkg: Fix Ecc error 3002 in TimerDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 06/25] ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 07/25] ArmPkg: Fix Ecc error 3002 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 08/25] ArmPkg: Fix Ecc error 3002 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 09/25] ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 10/25] ArmPkg: Fix Ecc error 3001 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 11/25] ArmPkg: Fix Ecc error 5005 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 12/25] ArmPkg: Fix Ecc error 5005 in ArmExceptionLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 13/25] ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 14/25] ArmPkg: Fix Ecc error 5007 in ArmScmiDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 15/25] ArmPkg: Fix Ecc error 5007 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 16/25] ArmPkg: Fix Ecc error 5007 in TimerDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 17/25] ArmPkg: Fix Ecc error 5007 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 18/25] ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 19/25] ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 20/25] ArmPkg: Fix Ecc error 5007 in ArmLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 21/25] ArmPkg: Fix Ecc error 5007 in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 22/25] ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 23/25] ArmPkg: Fix Ecc error 5007 in SemihostLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 24/25] ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib PierreGondois
2020-12-16 17:22 ` [PATCH v1 25/25] ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib PierreGondois
2020-12-18 18:31 ` [edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg Sami Mujawar
2021-01-06 16:23 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1482263-9b9e-c9d1-6919-56c093b6bb42@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox