* Re: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error
2019-09-16 22:39 [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error David Wei
@ 2019-09-17 0:15 ` Liming Gao
2019-09-19 3:57 ` Kubacki, Michael A
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2019-09-17 0:15 UTC (permalink / raw)
To: Wei, David Y, devel@edk2.groups.io
Cc: Wu, Hao A, Sinha, Ankit, Agyeman, Prince, Kubacki, Michael A,
Desimone, Nathaniel L, Kinney, Michael D
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Wei, David Y
>Sent: Tuesday, September 17, 2019 6:40 AM
>To: devel@edk2.groups.io
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Sinha, Ankit <ankit.sinha@intel.com>; Agyeman, Prince
><prince.agyeman@intel.com>; Kubacki, Michael A
><michael.a.kubacki@intel.com>; Desimone, Nathaniel L
><nathaniel.l.desimone@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name
>to fix build error
>
>MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of
>gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB.
>SimicsOpenBoardPkg need to update for it accordingly.
>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ankit Sinha <ankit.sinha@intel.com>
>Cc: Agyeman Prince <prince.agyeman@intel.com>
>Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
>Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
>Signed-off-by: David Wei <david.y.wei@intel.com>
>---
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 2 +-
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>index 90e6d1d3cf..ee0eead5a8 100644
>--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>+++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
>@@ -449,7 +449,7 @@ QemuInitializeRam (
> SmramRanges = 1;
>
> Hob.Raw = BuildGuidHob(
>- &gEfiSmmPeiSmramMemoryReserveGuid,
>+ &gEfiSmmSmramMemoryGuid,
> BufferSize
> );
> ASSERT(Hob.Raw);
>diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>index ccc7037d75..e466d57e4e 100644
>--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>+++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
>@@ -39,7 +39,7 @@
>
> [Guids]
> gEfiMemoryTypeInformationGuid
>- gEfiSmmPeiSmramMemoryReserveGuid ## CONSUMES
>+ gEfiSmmSmramMemoryGuid ## CONSUMES
>
> [LibraryClasses]
> BaseLib
>--
>2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error
2019-09-16 22:39 [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid name to fix build error David Wei
2019-09-17 0:15 ` Liming Gao
@ 2019-09-19 3:57 ` Kubacki, Michael A
1 sibling, 0 replies; 3+ messages in thread
From: Kubacki, Michael A @ 2019-09-19 3:57 UTC (permalink / raw)
To: Wei, David Y, devel@edk2.groups.io
Cc: Wu, Hao A, Gao, Liming, Sinha, Ankit, Agyeman, Prince,
Desimone, Nathaniel L, Kinney, Michael D
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Wei, David Y <david.y.wei@intel.com>
> Sent: Monday, September 16, 2019 3:40 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Change Guid
> name to fix build error
>
> MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of
> gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB.
> SimicsOpenBoardPkg need to update for it accordingly.
>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Signed-off-by: David Wei <david.y.wei@intel.com>
> ---
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 2 +-
> Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> index 90e6d1d3cf..ee0eead5a8 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> @@ -449,7 +449,7 @@ QemuInitializeRam (
> SmramRanges = 1;
>
> Hob.Raw = BuildGuidHob(
> - &gEfiSmmPeiSmramMemoryReserveGuid,
> + &gEfiSmmSmramMemoryGuid,
> BufferSize
> );
> ASSERT(Hob.Raw);
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> index ccc7037d75..e466d57e4e 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> @@ -39,7 +39,7 @@
>
> [Guids]
> gEfiMemoryTypeInformationGuid
> - gEfiSmmPeiSmramMemoryReserveGuid ## CONSUMES
> + gEfiSmmSmramMemoryGuid ## CONSUMES
>
> [LibraryClasses]
> BaseLib
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread