Re: [edk2-devel] [PATCH v2 3/4] NetworkPkg: Dhcp6Dxe: Packet-Length is not updated before appending

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2024-02-13 18:46, Doug Flick via groups.io wrote:
> From: Doug Flick <dougflick@microsoft.com>
> 
> In order for Dhcp6AppendIaAddrOption (..) to safely append the IA
> Address option, the Packet-Length field must be updated before appending
> the option.
> 
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> 
> Signed-off-by: Doug Flick [MSFT] <doug.edk2@gmail.com>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Thanks for this!

> ---
>   NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> index e4e072562296..f38e3ee3fe1a 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> @@ -924,6 +924,11 @@ Dhcp6AppendIaOption (
>       *PacketCursor += sizeof (T2);
> 
>     }
> 
>   
> 
> +  //
> 
> +  // Update the packet length
> 
> +  //
> 
> +  Packet->Length += BytesNeeded;
> 
> +
> 
>     //
> 
>     // Fill all the addresses belong to the Ia
> 
>     //
> 
> @@ -935,11 +940,6 @@ Dhcp6AppendIaOption (
>       }
> 
>     }
> 
>   
> 
> -  //
> 
> -  // Update the packet length
> 
> -  //
> 
> -  Packet->Length += BytesNeeded;
> 
> -
> 
>     //
> 
>     // Fill the value of Ia option length
> 
>     //
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115413): https://edk2.groups.io/g/devel/message/115413
Mute This Topic: https://groups.io/mt/104339708/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-