From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.67, mailfrom: philmd@redhat.com) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 18 Jul 2019 10:50:51 -0700 Received: by mail-wm1-f67.google.com with SMTP id l2so26558143wmg.0 for ; Thu, 18 Jul 2019 10:50:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hqFJA6OHnvSJOR2VBa5CsryCKKCUYxX3Ll4rxhv1nA8=; b=J04/mFW1WJDey1mzxA9nvnmmxMq9wRS4t7Kgf50tzp9Z6oQ76kZ6Fvck3FComRsRxa QECXNV0ZFq7gTb2bSdM4wHGyI75qdFMAaF+/TEIsH4Skd0DsXXAG4IhADXm8BRxp2K+p DKJ3ciDGoet0osSDPiXz13y/NiBItdcMOvjJvWGtsN/YG83FyepBD4ZOPxj8CkKTGlu2 hkYHPcVCuzwTgPKOFNZdr+SF2OWGN7HLQxG98kjPJIEd68S42xr/+s3r66CQmYVIoXU5 DlpBwru8rWtnpcFxs4vTf5MCp6fUkFv/Wn2YFzCfSXmtI1vOiiQHVdkQHQh9xaar4IgX /TKw== X-Gm-Message-State: APjAAAUTd9Qx/U4s0oLOC9otyCqqi8ZRL/ve1/8zujWXoxA5hRCHG+Zk HDjQpl1cKRlmaPoOaADIVw5ojA== X-Google-Smtp-Source: APXvYqzBJmdzkNCqIH9A7onKJR5pzguhNVau2Zj3z1hK3tUNycfWJkUw5l1k4r2skP80Qd8chJGvgQ== X-Received: by 2002:a1c:2e09:: with SMTP id u9mr43732636wmu.137.1563472249465; Thu, 18 Jul 2019 10:50:49 -0700 (PDT) Return-Path: Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id y16sm56009857wrg.85.2019.07.18.10.50.48 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2019 10:50:48 -0700 (PDT) Subject: Re: [PATCH 0/3] add GetMaintainer.py helper script To: Leif Lindholm Cc: edk2-devel-groups-io , Andrew Fish , Laszlo Ersek , Michael D Kinney , Bob Feng , Liming Gao , "Wu, Hao A" , Stefan Berger References: <20190712170128.6495-1-leif.lindholm@linaro.org> <20190718174010.GJ2712@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 18 Jul 2019 19:50:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190718174010.GJ2712@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/18/19 7:40 PM, Leif Lindholm wrote: > On Thu, Jul 18, 2019 at 07:01:40PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Leif, >> >> On 7/18/19 6:27 PM, Leif Lindholm wrote: >>> Laszlo, Hao - I have prepared a set for pushing as below. >>> >>> (Reviewed-by: Leif Lindholm >> > for all of your patches.) >>> *But*, I need a review from  Bob and/or Liming before I push the final one: >>> "BaseTools: add GetMaintainer.py script" - >>> https://edk2.groups.io/g/devel/message/43666 >>> >>> I have verified reviews/acks by all affected reviewers, except for >>> Stefan Berger for Ovmf TCG/TPM2. >>> While I would prefer to have that too, this is a file format shift - not >>> a change in responsibility areas. >> >> As Marc-André and Stefan have the same responsabilities, Marc-André's >> review for their common section should be sufficient, right? > > Pretty much. > >> Now if you want to be kind and patient with Stefan, since this is not a >> logical change blocking anyone, it might be wise to wait over the weekend. >> >> My 2 cents ;) > > Yeah, only thing is it would be nice if we could get the script in > (which is dependent on the Maintainers.txt changes in order to not > give misleading results) with some time to spare (and for it to see > real-world use) before we start the freeze for edk2-stable201908. Then I insist, since Marc-André reviewed the patch, except for being particularly kind, I don't see any reason to not merge your series ;) Regards, Phil.