From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Leif Lindholm" <leif@nuviainc.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
Date: Mon, 21 Dec 2020 13:17:33 +0100 [thread overview]
Message-ID: <c169dcde-a67a-8c4a-a60f-4f69a216af6f@arm.com> (raw)
In-Reply-To: <20201221113657.6779-1-lersek@redhat.com>
On 12/21/20 12:36 PM, Laszlo Ersek wrote:
> Repo: https://pagure.io/lersek/edk2.git
> Branch: timebaselib_uintn
>
> Through the virtio-fs driver, EmbeddedPkg/TimeBaseLib got exposed to
> VS2019 for the first time. VS2019 flagged an arguably unintended,
> implicit UINTN->UINT32 conversion in EfiTimeToEpoch(); let's remedy
> that.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Laszlo Ersek (2):
> ArmPlatformPkg/PL031RealTimeClockLib: cast EfiTimeToEpoch() val. to
> UINT32
> EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
>
> EmbeddedPkg/Include/Library/TimeBaseLib.h | 2 +-
> ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +-
> EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2020-12-21 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 11:36 [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit Laszlo Ersek
2020-12-21 11:36 ` [PATCH 1/2] ArmPlatformPkg/PL031RealTimeClockLib: cast EfiTimeToEpoch() val. to UINT32 Laszlo Ersek
2020-12-21 11:36 ` [PATCH 2/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit Laszlo Ersek
2020-12-21 12:17 ` Ard Biesheuvel [this message]
2020-12-21 15:57 ` [edk2-devel] [PATCH 0/2] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c169dcde-a67a-8c4a-a60f-4f69a216af6f@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox