From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0B9D82120 for ; Thu, 23 Feb 2017 08:10:35 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B981C054C3E; Thu, 23 Feb 2017 16:10:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-58.phx2.redhat.com [10.3.116.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DE97B6FC7; Thu, 23 Feb 2017 16:10:35 +0000 (UTC) To: "Gao, Liming" , Anthony PERARD References: <20170223124208.5402-1-anthony.perard@citrix.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E3754@shsmsx102.ccr.corp.intel.com> Cc: "edk2-devel@lists.01.org" , "Justen, Jordan L" From: Laszlo Ersek Message-ID: Date: Thu, 23 Feb 2017 17:10:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E3754@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 23 Feb 2017 16:10:36 +0000 (UTC) Subject: Re: [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 16:10:36 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/23/17 13:57, Gao, Liming wrote: > Reviewed-by: Liming Gao Reviewed-by: Laszlo Ersek Committed & pushed as c5c9e7e298ed. Thanks! Laszlo > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Anthony PERARD > Sent: Thursday, February 23, 2017 8:42 PM > To: edk2-devel@lists.01.org > Cc: Anthony PERARD ; Justen, Jordan L ; Laszlo Ersek > Subject: [edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint > > ... because this function use VA_COPY. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenBusDxe/XenStore.h | 1 + > OvmfPkg/XenBusDxe/XenStore.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/OvmfPkg/XenBusDxe/XenStore.h b/OvmfPkg/XenBusDxe/XenStore.h > index c9d4c6509a..33bb647f66 100644 > --- a/OvmfPkg/XenBusDxe/XenStore.h > +++ b/OvmfPkg/XenBusDxe/XenStore.h > @@ -209,6 +209,7 @@ XenStoreSPrint ( > indicating the type of write failure. > **/ > XENSTORE_STATUS > +EFIAPI > XenStoreVSPrint ( > IN CONST XENSTORE_TRANSACTION *Transaction, > IN CONST CHAR8 *DirectoryPath, > diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c > index 76b6e297ef..6812e1078c 100644 > --- a/OvmfPkg/XenBusDxe/XenStore.c > +++ b/OvmfPkg/XenBusDxe/XenStore.c > @@ -1304,6 +1304,7 @@ XenStoreTransactionEnd ( > } > > XENSTORE_STATUS > +EFIAPI > XenStoreVSPrint ( > IN CONST XENSTORE_TRANSACTION *Transaction, > IN CONST CHAR8 *DirectoryPath, >