From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.20081.1574164299794395417 for ; Tue, 19 Nov 2019 03:51:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IzXDeWvc; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574164298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=glsRjZoVpGYoxT1irQS/hqX0xBNE5h75MXmv6f57sNg=; b=IzXDeWvcupuv+UxzEDauVNc06JE832z3LT1hB7fAbR/fg9mSK2RSWTnMBmYMyGWrQKNw7J ot0eQKBSi/QWIT/WjbBLwG4qtIADUHOYE9TNQCQLh3pwnLgdWc0KzRj2Ih59YwT+wZFfqh GD1p5sOaCxBsTOYnCH3DsMLZNExyHts= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-LnuJ66v8P4ScKIkGDQbh3w-1; Tue, 19 Nov 2019 06:51:35 -0500 Received: by mail-wr1-f69.google.com with SMTP id y1so18267874wrl.0 for ; Tue, 19 Nov 2019 03:51:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jAv0VuPwunMhYPBUpU7+hU4sf2hBHQrZKyHdX7Kc/fk=; b=tru4xEp/W4wl5RmicGWMaETJUHSlP0Wee54L9DSWinJh/PsZSI/V9u/zU/J1yrHK35 ZAF6fe14jz/jshm5698IbsNvScMPFrHl9H56w38I0K44lzjPZY+1Fk+SE+wmOMA2bgqG KoS3dS8dIX1xsIUNyFyaZodntHtDBQflublycQ3j3wdJqt0w0cf0bm+a/2btHt+YcGre 0uZ2oviqqtSn4gXRJVeI5kkZk+3IK5b1y0HSVGwIirZQIoFc9JlpDxf563BFsZ6gchcv luhAUmGK0O+fSNFsjCWy6u2YswznlLMAtUoK/Y8y1fB2ZSPWzSZ4KhdGoacWaTqWF+UG UUqw== X-Gm-Message-State: APjAAAWMfLVFhNFdOM4CYbFqsWgG4WoinJb9RYjCZptUJStkBcCKXszd SH+xDJPvokZtR7zZsewJF5MXoT1VwrLZzAyoWOwPs2jgjL6fjAuJ9KH+BWckfSEaVvFdnyI+RZa k8to0ucjpwJFodw== X-Received: by 2002:adf:da52:: with SMTP id r18mr36607090wrl.167.1574164294235; Tue, 19 Nov 2019 03:51:34 -0800 (PST) X-Google-Smtp-Source: APXvYqxGrADzbA9JeZh2ElHe1kwFSLk40pTYT5iA6M5VhWjxw4EsdhuxWVc7tsId9RR+29kC4nGJng== X-Received: by 2002:adf:da52:: with SMTP id r18mr36607064wrl.167.1574164293989; Tue, 19 Nov 2019 03:51:33 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id d20sm29981172wra.4.2019.11.19.03.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2019 03:51:32 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 5/7] Silicon/Broadcom: Add Bcm2711 header To: Pete Batard , devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, samer.el-haj-mahmoud@arm.com References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-6-pete@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 19 Nov 2019 12:51:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191119113809.2472-6-pete@akeo.ie> X-MC-Unique: LnuJ66v8P4ScKIkGDQbh3w-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/19/19 12:38 PM, Pete Batard wrote: > Bcm2711 is the SoC used by the Raspberry Pi 4. For the most part it > is backward compatible with the Bcm283x SoC used by older models but > some new Bcm2711 registers have been introduced such as the ones for > PCIe. >=20 > We therefore introduce a new Bcm27xx module, which contains only the > base address for the new registers for now (set from a PCD as is the > case for Bcm283x) but which should get populated further as we add > support for the Raspberry Pi 4. >=20 > Signed-off-by: Pete Batard > Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude > --- > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 22 ++++++= ++++++++++++++ > Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 15 ++++++= +++++++ > 2 files changed, 37 insertions(+) >=20 > diff --git a/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec b/Silicon/Broadcom/Bcm2= 7xx/Bcm27xx.dec > new file mode 100644 > index 000000000000..815302f6d209 > --- /dev/null > +++ b/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec > @@ -0,0 +1,22 @@ > +## @file > +# > +# Copyright (c) 2019, Pete Batard > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + DEC_SPECIFICATION =3D 0x0001001A > + PACKAGE_NAME =3D Bcm27xxPkg > + PACKAGE_GUID =3D D4B585C5-EBCA-4779-B974-05A3CF2F10C= 4 > + PACKAGE_VERSION =3D 1.0 > + > +[Includes] > + Include > + > +[Guids] > + gBcm27xxTokenSpaceGuid =3D {0x44045e56, 0x7056, 0x4be6, {0x88, 0xc0, 0= x49, 0x0c, 0x67, 0x90, 0x2f, 0xba}} > + > +[PcdsFixedAtBuild.common] > + gBcm27xxTokenSpaceGuid.PcdBcm27xxRegistersAddress|0x0|UINT32|0x0000000= 1 > diff --git a/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h = b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h > new file mode 100644 > index 000000000000..356458024e84 > --- /dev/null > +++ b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h > @@ -0,0 +1,15 @@ > +/** @file > + * > + * Copyright (c) 2019, Pete Batard . > + * > + * SPDX-License-Identifier: BSD-2-Clause-Patent > + * > + **/ > + > +#ifndef BCM2711_H__ > +#define BCM2711_H__ > + > +#define BCM2711_SOC_REGISTERS (FixedPcdGet64 (PcdBcm27xxRe= gistersAddress)) > +#define BCM2711_SOC_REGISTER_LENGTH 0x02000000 > + > +#endif /* BCM2711_H__ */ >=20