From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.8892.1589384241930459112 for ; Wed, 13 May 2020 08:37:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YG82nHb5; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589384241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mrAHHAkXKcxuPUZQFy4OL6kFiNoHB/M/BPOnQjyHgo8=; b=YG82nHb5NNZoUsuMDqWrR9dbinjMuuA2bt0JosRT3EH0W422Lr6DTYUv24VCq4Ab+jovtS 0j5SkMf4H2aFlDPS8BD/v4STqjk5I7EMKT3i2Av5HUDMhsf05MmWpUDSejyJOGumqAPYsF laeXZxYotlvDgF+ZBpQX59uf5Te9tq4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-5vOdPXJtOEmHvSDeF9H2ew-1; Wed, 13 May 2020 11:37:12 -0400 X-MC-Unique: 5vOdPXJtOEmHvSDeF9H2ew-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5DA04107ACCD; Wed, 13 May 2020 15:37:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05A2A61541; Wed, 13 May 2020 15:37:09 +0000 (UTC) Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib To: Bret Barkelew , "devel@edk2.groups.io" , "cheptsov@ispras.ru" Cc: "Dong, Eric" , "Ni, Ray" References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-25-cheptsov@ispras.ru> From: "Laszlo Ersek" Message-ID: Date: Wed, 13 May 2020 17:37:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8bit On 05/13/20 16:43, Bret Barkelew wrote: > Having only ever used PRs, what does that mean? He should have copied the “R-b� text and amended that commit message in this version? Yes, exactly. Perform an interactive git rebase, set "reword" as the action for the subject patches, and append (cut and paste) the R-b tags from the emails to the commit messages. Thanks! Laszlo > > - Bret > ________________________________ > From: devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io > Sent: Wednesday, May 13, 2020 4:07:34 AM > To: devel@edk2.groups.io ; cheptsov@ispras.ru > Cc: Dong, Eric ; Ni, Ray > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib > > On 05/12/20 19:02, Vitaly Cheptsov wrote: >> REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2054&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=uE8hQ1goSvrnyjx8orh6l3%2BuS%2BzlOpZtXZylsEEzHBo%3D&reserved=0 >> >> CC: Eric Dong >> CC: Ray Ni >> CC: Laszlo Ersek >> Signed-off-by: Vitaly Cheptsov >> --- >> UefiCpuPkg/UefiCpuPkg.dsc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc >> index d28cb5cccb..f5f407ad23 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.dsc >> +++ b/UefiCpuPkg/UefiCpuPkg.dsc >> @@ -27,6 +27,7 @@ [LibraryClasses] >> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf >> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf >> + DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCommonLib.inf >> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf >> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf >> > > Again, identical to the v4 counterpart. Should have picked up my R-b. > > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmid.mail-archive.com%2F0d0b6b6f-39c8-4056-c496-07151e33cdd5%40redhat.com&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=X%2Bvi9LqaswphH3DM63JWIK2UJP8%2B%2BxDOBEkmDCF6%2FPw%3D&reserved=0 > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F59202&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=ECkvl%2FeXKWbud%2FsNB2%2BusXff9HY%2F7OWx%2FFD5DejhC3c%3D&reserved=0 > > anyway > > Reviewed-by: Laszlo Ersek > > > > >