From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3C212AC1475 for ; Thu, 2 May 2024 15:21:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1rASLuET23ce+DlXvXE2ZoP13lWvO+/OOz62cp1AhB8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714663283; v=1; b=AwHyiSX4BDOYQH3hVSQT6YiCUDzP2Fwn5YBu1ESFazb4cmo9omsVW98CWdilcOzun/SRglSF mjqjkCOFMl/H1KdcoTX/2udIDhcYNvLemeOBWBuC57CCF4QobGVIYg4i/OW7C0B+6LMteLeG8BO XsvtHljvQbUrdXrRbREmfjsP09wRyenu10L00J1VUDQiQ8MkpKar/TLzQkf3Fn2mdQizbwqW9P5 0l/8fUHPmX8qbsL44KriWKltM+Gi2+GRc+RscwXXthFCn0BjzSgslwv/uGyJYPwZacqaBS+3OB3 meYjFI5NvS9s0mF4mhyRzmkGDOawMplP6xSst+D1rA1Dg== X-Received: by 127.0.0.2 with SMTP id 28AdYY7687511xHNlUmdhm7A; Thu, 02 May 2024 08:21:23 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.8465.1714663282966943255 for ; Thu, 02 May 2024 08:21:23 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.6]) by linux.microsoft.com (Postfix) with ESMTPSA id BCE5B20B2C80; Thu, 2 May 2024 08:21:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BCE5B20B2C80 Message-ID: Date: Thu, 2 May 2024 08:21:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org, michael.d.kinney@intel.com, "rfc@edk2.groups.io" Cc: Leif Lindholm , "Andrew Fish (afish@apple.com)" References: <1a957a2a-f055-4af8-bdca-e6117a0dd5ae@linaro.org> <48c29377-f274-4e78-865d-3bda9607727b@quicinc.com> From: "Michael Kubacki" In-Reply-To: <48c29377-f274-4e78-865d-3bda9607727b@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 08:21:23 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d7OCTj6SN5XbkEAYKAhD6ZCWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AwHyiSX4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/2/2024 6:34 AM, Leif Lindholm wrote: > On 2024-05-02 07:33, Marcin Juszkiewicz wrote: >> W dniu 1.05.2024 o=C2=A019:43, Michael D Kinney via groups.io pisze: >>> I would like to propose that TianoCore move all code review from email >>> based code reviews to GitHub Pull Requests based code reviews. >>> >>> The proposed date to switch would be immediately after the next stable >>> tag which is currently scheduled for May 24, 2024. >> >> O yes! Fully for it! >> >> Does it mean edk2 only or edk2/edk2-platforms/edk2-non-osi and other=20 >> tianocore/ repositories? >=20 > I don't see why we couldn't switch all of them. Other than we need to=20 > get all the Maintainers.txt updated with code forge usernames first. >=20 > We may want to do one at a time though. >=20 > / > =C2=A0=C2=A0=C2=A0 Leif >=20 >>> * The Pull Request submitter is required to invite the required >>> =C2=A0=C2=A0 maintainers and reviewers to the pull request. This is the= same >>> =C2=A0=C2=A0 set of maintainers and reviewers that are required to be l= isted in >>> =C2=A0=C2=A0 Cc: tags in today's process. >> >> That can be done by github action started automatically after opening=20 >> PR. May require changes to GetMaintainer.py script. Would be good to=20 >> have in case someone forget to add one of maintainers. >> >> Also would be nice to have a bot running PatchCheck and uncrustify on PR= . >> Yes, this would need to be in a GitHub workflow so it could parse the=20 file and ultimately use the GitHub API to add the maintainers. As I=20 mentioned in another email, my team has experience doing this and we're=20 happy to help where we can. >> >> >> >> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118523): https://edk2.groups.io/g/devel/message/118523 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-