From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web11.2046.1589995567561764680
 for <devel@edk2.groups.io>;
 Wed, 20 May 2020 10:26:07 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EMbtwErb;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1589995566;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jE4Z9ypeNgtEysX8EGibu/hTFoy8HrWRe5CQptl+FGM=;
	b=EMbtwErbMlxAQitJzi6J4UyFpSr9xClJdbZ7lkAIycKHdCUKKpGAFJcwfuQx0x4wT0Z88j
	cr8izpdlAnsBVVHK/UlCkfFt7sT/eGZhpqoI+0OkH57CeBP8vnt9dQWFpAacKoAE1w2NOe
	1b+GJQs7NvYlHyRUjsBGVT0cS066+VM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-188-YtjAtLgqMgiznLH_AN3ojg-1; Wed, 20 May 2020 13:26:04 -0400
X-MC-Unique: YtjAtLgqMgiznLH_AN3ojg-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 992ED64AD4;
	Wed, 20 May 2020 17:26:02 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-121.ams2.redhat.com [10.36.115.121])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 7700460554;
	Wed, 20 May 2020 17:25:59 +0000 (UTC)
Subject: Re: [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ard.biesheuvel@linaro.org>, Bret Barkelew <bret.barkelew@microsoft.com>,
 "Brian J . Johnson" <brian.johnson@hpe.com>,
 Chasel Chiu <chasel.chiu@intel.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Leif Lindholm
 <leif@nuviainc.com>, Liming Gao <liming.gao@intel.com>,
 Marvin H?user <mhaeuser@outlook.de>,
 Vincent Zimmer <vincent.zimmer@intel.com>,
 Zhichao Gao <zhichao.gao@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
 Vitaly Cheptsov <vit9696@protonmail.com>
References: <20200520031108.9644-1-michael.d.kinney@intel.com>
 <20200520031108.9644-3-michael.d.kinney@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <c1c345cd-5965-0284-124b-8dffaf82a563@redhat.com>
Date: Wed, 20 May 2020 19:25:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200520031108.9644-3-michael.d.kinney@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 05/20/20 05:11, Michael D Kinney wrote:
> Use the safe string function StrCpyS() in BaseLib to test the
> SAFE_STRING_CONSTRAINT_CHECK() macro.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Bret Barkelew <bret.barkelew@microsoft.com>
> Cc: Brian J. Johnson <brian.johnson@hpe.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marvin H?user <mhaeuser@outlook.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Vincent Zimmer <vincent.zimmer@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../UnitTest/Library/BaseLib/Base64UnitTest.c | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)

I'll defer to other reviewers on this patch.

Thanks,
Laszlo