From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.2894.1626239494048445907 for ; Tue, 13 Jul 2021 22:11:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=AZTztQrt; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=08293528a9=daniel.schaefer@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16E58FGe016128; Wed, 14 Jul 2021 05:11:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=hmeSLtw7E7jhyO+RcCWmitR2L0lmajEJ8gZcPvas+7A=; b=AZTztQrt4o1FGLf2FiA5I6DeU5Iz80e2gba1vzLFpzgmGSmghf3N7OsIfWN80sgiHCGI uz8zhTvDGKd99vCrQA6axQyu0AarsEW2OOJst8lz7aJ5b4FgZgLoKw3PWG35at/vq0KJ E/mGc0ur2stoabzs/QvHfF5ubgukcsqAD9LW5vz0CSgYQGL9ssYXXvhfidLU7FvtsLGK OJ4b+Jd4DCjj8ryjJ80oJ/sv6B8ZguUl1Dc1MVhUmZ3YTr4MAK/doJapeZAUqvCKenDY xgMcHn4Izv/eg6H/40PVptyEifMzc18ihC2Ea0IemEkBWmIre2mAnGxTZ6xJaX/vPlai 9g== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 39se6r4x3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 05:11:33 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id C143855; Wed, 14 Jul 2021 05:11:32 +0000 (UTC) Received: from G9W8674.americas.hpqcorp.net (16.220.49.0) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 14 Jul 2021 05:11:32 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W8674.americas.hpqcorp.net (2002:10dc:3100::10dc:3100) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 14 Jul 2021 05:11:31 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Wed, 14 Jul 2021 05:11:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fp4hKoDSYk66wUOIvGzdnt6KNb97pjAwpHOVRV+Dqk9yn3E3ICc5L0S8IQpzEaJhVOuiuqqFA1c6S8uqiOeiPek320N/7xMImWr64zVpeYQaVVb4hOStm2vYzOa5tUJb8olNr6PnGG4F80jxSrrvnQqUNtPS0o2b7aW3FLTnjNVrfUY0sGc5LC+JYo/UaSEaEFFCyi9OMZan+OvLqerE0rlDXouMDUVTp6OkdPFGWGQBKxq7PtHrgU5hdbFVBNrmTLjwZbc1FrNw3QJQ2313LVq9py4382qauFNf4P22GM/Kgl9zFe3JvyvBXKbWialPkaFgjJn7dhn7Xo1ZKsC//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RaWukX5i9qZQeKT38JisKulOSquTcMOutpff4EzzIcE=; b=MBJAfuEmYlgKsCmcbeU68PMnJbpqAx9qrwR/pqPM+fFI3HrAqQJJK2DIno4HMPFv0cwn9lHjJTWbCSpAN7wleXOocYtIf00x9FOAEaiB8vaJeSGKYt0wKDfa303vGH/wiD8aJyO3uduRGYOwmp+KJ8NM3ONpdAp5a5f5P0LUmfdkkUSXvJkaIP8eGAxcU9D1+jW0CMVPLxslH00t/LIT+giEsqyOvD2znBPUrubGU7+Hv90jfZQl/3VoLSz8pMKyiiwxCugtRyO68/GyyaE8kdTCeMgsg1QRdEBfcnScaJFIz135Ld7fnIBDivOScM2xqObbm5SvLjWnpH0/rLYMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0665.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 05:11:30 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a%5]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 05:11:30 +0000 Subject: Re: [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files To: Takuto Naito , CC: Abner Chang References: <20210713152455.61236-1-naitaku@gmail.com> <20210713152455.61236-2-naitaku@gmail.com> From: "Daniel Schaefer" Message-ID: Date: Wed, 14 Jul 2021 13:11:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 In-Reply-To: <20210713152455.61236-2-naitaku@gmail.com> X-ClientProxiedBy: SN4PR0401CA0012.namprd04.prod.outlook.com (2603:10b6:803:21::22) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.42.127] (123.193.59.220) by SN4PR0401CA0012.namprd04.prod.outlook.com (2603:10b6:803:21::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 14 Jul 2021 05:11:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9eeba803-cca6-4e5c-c083-08d94685d722 X-MS-TrafficTypeDiagnostic: DF4PR8401MB0665: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KVbmkvNJfSUDcxsgNzJarQ1yJ0EBaqb3ZV4NBqrvh7/J/ly4li/uZ7YwhFpnqDVenSgu6MUTqDg52xeW/rtUNvgMVmIlwtlepUJJf4tjEmg7Q7+AZsQFP5ggaXBMftqDI9bLbjM1GGYyLVQlq445cBuK6D3zhmhNh4PsRf9B+Dt/wrL/fZ0fhNWPGzS1SpHSWHVhsJQWv8UrWj3FOoXV21k0Zv3/z07TbFqJnyG4G4+xemHc03QVnyz6HqIRSRnA2YqkZBdPV5wpZOWunUWolGTjnkQlr2P00Wtwdiig6+DgDCgQW2H+7seYmRECgt+Hczbrt/QfKVe5BU+CFracWOMI81bEve1ec4TI5p8tUr7ZBczveeigmHWzqTSGAzExiod0Xiyc2Ct2FiVPQNxXxaeeM/H2dtBGOQES6u8Uf9mqlnd8atTPF/fkgDNE1GRUNuavt4D0FqoESswCKpHTYX5LgZe+RRbmyfkTPl/jqr+Bw6FWj5NxUmC1Jr4ijDaVTgDI0ccWT9Jok6Dm12GVkVbezxkFe8shjTaziiwyKU+Kcacn8tWPSBdi/LoUNPdNBGEs3ZYnQZ6eJnNCAJoI3Js8cS4JYLskUWwtxWcwfe2PBhG26bnce9rzosnxuMtcEYA4K5i4JSJUsEeCYQcX7tPlGFxrgAnI5GT2qcmko+qgopFcpQOaryH15sMv9LHxn45n0sty89tsXihGisMW38s8dHOxQ7a4z/vikKN39u+hdlJO5Gq63B0WNn5xXS9TQC8QRYXGBwjZpYvwsZFV091OP+IHGq0XqqHu0GKNxG/gDSTWmb4tAjy2mIoAZzPn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(396003)(346002)(39860400002)(366004)(376002)(136003)(66556008)(26005)(2616005)(956004)(44832011)(8676002)(6486002)(66476007)(86362001)(4326008)(6666004)(31696002)(66946007)(478600001)(8936002)(186003)(316002)(5660300002)(83380400001)(53546011)(36756003)(31686004)(16576012)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0ZuTmRuQmFPdzNIWTdKSXJlc2hlR1UySERjZEdLRzNUblp6L212MmFyWWN2?= =?utf-8?B?WjZHVFkxbzNrSDVmbzYyWWVnMXgyNWVtTXJUU0hDSElMaW5uRVFEOXpLdCtW?= =?utf-8?B?ekxMZ0ZOR2tWenI3MmN6a2xYd1pvNGE0b3pCQlpZTE5IN0Q4dEM3ZkdBdTV5?= =?utf-8?B?WHhvaHFWS2tqL013RzZocjI5V1B6aHFTU0xqVXV6by9vYklWQVJXSDcrV1J5?= =?utf-8?B?QmRxT1VlMGIwN3RoT3hSN3laU1lWb3VTOW1ORUdXZXc0VTAvazYrMDBzUXhy?= =?utf-8?B?QjU3bHZZOGptczQ5UG9jTVFPazZYa3dhTklHYUtSVGFzS1NTQnlsRitRTmln?= =?utf-8?B?OFdVNUpqd2VLQ2hZZnNQNlhsem1CeTFKSXVSbHRpTU9lZnYxWHdqMm5ibXk5?= =?utf-8?B?bEwvejZma0k5ci9CSkMzZFdCZzA1aXU2Y1JFZkFBSTRYOXMyZ2FWVEFmdWhF?= =?utf-8?B?Ui9CK1lVTVhaYVlSb2JCZ2hnaTRKa0M5aDgrSE1wb2ExVXBiNGlzaGRuZDJ5?= =?utf-8?B?TXNTd3RpbmhITE01cE5QN1dvUFhWMU5uWVgzOFZ3OFdDcHo4SmhOTm5Od0Uw?= =?utf-8?B?ZDAyZ004OEdBRm4vaitnK01pY0sxb0QrK0NCcEhJQUJKS21DTEx0S2IyTmR3?= =?utf-8?B?L0I0UTZ0OUF4d3oyOXdMSDlGRzlsQ29YbFBzR2JmWi85Um80SGlCOE4veHF3?= =?utf-8?B?K1dSd044eEE3aXMyTlVBaVF6SWZaVmpXbkFqUWZxOUdoZEpIWDhnakJlWEp0?= =?utf-8?B?L1F0dzhFZWhmdlhQc1JZa2RMOXBDOS9PaVVvUUJjZEtDSXhtdy9yMStWa0hP?= =?utf-8?B?cjh2S3d2Wnc3ZFRkUVpnMVRiTkJKdVlVMWZKOGx4UEw2cjVTcGw5VlJ4bnc0?= =?utf-8?B?ZTl2RzJ3d3E3eTd6NWtIeFRabitEMmordkJ0NU1zNWtnMTBTdWhITmliYkxF?= =?utf-8?B?SGxIQURyZzhBdGorYkVZOERGYldBYUYzNkVxZ3FXd1ViOTArNWxOSzlITzdh?= =?utf-8?B?REszcHlreU00NGE3c0xoaTBsYUF6MmtqbFRyb3RvZm44aEVRaHcyd2swaCtu?= =?utf-8?B?aTNpYmxYc08wRmR3d3NOcHliYnpHVjgwUzIyM3d6YVMxNVM5eWErTStWMXNB?= =?utf-8?B?WXFNWERLNFZNMGIzSGNUeUZob0d5OFdMNEF2NEFlMEpHbVg0MFltWSt6bHg0?= =?utf-8?B?aFh6SnZtdi9qQ1NwZlFmTkRNTHg4V2tYeU0zVTh2WDVENlRsbFdIcjhxVC9W?= =?utf-8?B?ZlE3NDQxNUw3ZC81eEV0RXlXaHNSNzNNZnZ2K2I3ZjVaTmZZb0RpbDZ5Nm5F?= =?utf-8?B?bTRtSnVkMWV0bEI4VUVaNDRYNm0ra0RrWnJ5RzFZMnAzYjAvUWYrSElMeVQv?= =?utf-8?B?VjdWT244VkZObmNkVEZIVkx5L2ZYb0c1cUt3aGgvaXAxS0F4VTlKY05Ed2F2?= =?utf-8?B?b3dKdEtHTERCNytuS0NZblhRYmFmbXBSL3I1WXo4TDE5ZVhPb0U4dXhMbnU2?= =?utf-8?B?YzJlYXZWV0pFMEVpOTlRLzRTRDVOTkF5YUZGcHhBQzlwVGJ3Nm4xYm5wRkF0?= =?utf-8?B?RTVmVndXM2kyYlk5N2p3L1N0TkJnNlFlalpYb2RlWUxYS2hFUy9wM1M2WWww?= =?utf-8?B?SmZza3pPamEwQktndzZRK1NyV2FGM2NMVERoVGpBZW8vbDBwWERtQ0djNkRU?= =?utf-8?B?bGNDSjd6akJndUpGc0kyWHpCc2lHMzlqNTdrY2hPcjduUlJFN1NBT0tpa2NM?= =?utf-8?Q?/HF0u2XpMDOnW+tP+DKNyEDXcHNWxUV+neRIMSn?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9eeba803-cca6-4e5c-c083-08d94685d722 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 05:11:30.4988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HnKcOWVlBXD8+nEUzWc3Hm2GTalsfdmZ+h8LVLm38roA7CeDrpnpvP9t/J6TwE+ZRDj0wX8aIzxJUXW9IZyrKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0665 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: X3OQzebGPkFA2EA1fitP5vqQkMsUoJ9t X-Proofpoint-GUID: X3OQzebGPkFA2EA1fitP5vqQkMsUoJ9t X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-14_03:2021-07-14,2021-07-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 bulkscore=0 clxscore=1011 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107140031 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks! Reviewed-By: Daniel Schaefer On 7/13/21 11:24 PM, Takuto Naito wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489 > > Fix build error of U540 and U500 caused by BdsDxe. > The edk2 patch > MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy > requires VariablePolicyHelperLib, but U500.dsc and U540.dsc > didn't have it in the LibraryClasses section. > > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Daniel Schaefer > Signed-off-by: Takuto Naito > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + > .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index b91823ceeb..2031265806 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -99,6 +99,7 @@ > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > # RISC-V Platform Library > TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > index 0eafe29880..0262b2a909 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > @@ -99,6 +99,7 @@ > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > # RISC-V Platform Library > TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf >