From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.57]) by mx.groups.io with SMTP id smtpd.web10.80063.1638292693862450688 for ; Tue, 30 Nov 2021 09:18:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=wIkL6zKd; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.57, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZF7uHSrp17wVSQO572XfCggyn16xZc/nwP8u/OOyrNiwjTK6Hz4zkD/pTj4PIcixEBnFCqwJl+D+ISgiwtNFELmcbCbWxRHhXbgW20ODDDX2k7vKPx+JnQblHomqOoIyP+mfDL8KhNAs6W6oQoOQXn456B1zBKv4MsPryopPBMDxk9eiVxsrXRjz0sXQCmd3eVgUOWY62XwWMEf8FE6kpNQSMZ/sLHh8E3gR6kLN6V12LxBhdsf3cnRzRBroeympuU1CxUQ2adnd+aVjmEyfN4lFk+s5NWMD8zd5pmdk9QSDaTL1leqjN4aczs9nLXWwwVFCmVpDx1olrks+KaO2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UiHgczPooihNncLmMcbaKBRhMv0zBVP+MGJj41v1NdA=; b=BP+GvZN8ZH7atyVPG1OtW99PCkO+yLuoyaik7FsPfP0SU6EFaxQ9u2VuibdJz/FapC5HaiV4Q921Qesf9m/NuZW2g50g41vtjRt+YRK72hI3YSgO2S70Qnr0O5bbYOBch8cOEor562bGUOerZlT6L9FeCQBVV47JN0Wv0By2k96wcD6oWj84BIr57hFtrPOSE86u7SGOaMrbrPMiiibRjuYdJmUBbJ7vbAHgTl7fo+TfOjEjlFbm+5Bu8FTy64QQaXylZELemTS7MwH2KwgaJBoUEKi0fHJX1GUpzIeqsZ0dpyH9hI/MsUWFPUAY6KXftCj6FntaESikY0ToNu6jnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UiHgczPooihNncLmMcbaKBRhMv0zBVP+MGJj41v1NdA=; b=wIkL6zKdSRaLMwk9vW5I/eZCjE/VugkiBIRzEUakK6wGUWi4BgVRMXQu+NElD86XaU8boJdoEXq0PZlwkKKg62fZcdeeeYP/AMqxIZvO1i6upxrLUpTKWGNCt/Yy9VYF1E9LXzhtilJArETltjXEiwzFirHOYrhLuzAQonI2nxU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2447.namprd12.prod.outlook.com (2603:10b6:802:27::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Tue, 30 Nov 2021 17:18:11 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c%5]) with mapi id 15.20.4734.024; Tue, 30 Nov 2021 17:18:11 +0000 Message-ID: Date: Tue, 30 Nov 2021 11:18:09 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Cc: brijesh.singh@amd.com, Tom Lendacky , qi zhou , "erdemaktas@google.com" , "jejb@linux.ibm.com" , "jiewen.yao@intel.com" , "min.m.xu@intel.com" Subject: Re: [edk2-devel] [PATCH] OvmfPkg/MemEncryptSevLib: check CPUID when read msr during PEI phase To: Gerd Hoffmann , devel@edk2.groups.io References: <37990bf4-d440-ce19-367b-8498c153ca76@amd.com> <20211130155116.a5weqz7o6knepxio@sirius.home.kraxel.org> From: "Brijesh Singh" In-Reply-To: <20211130155116.a5weqz7o6knepxio@sirius.home.kraxel.org> X-ClientProxiedBy: SN7P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::12) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from [10.0.0.6] (70.112.153.56) by SN7P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Tue, 30 Nov 2021 17:18:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 697ffc92-7474-4153-c81c-08d9b42562c1 X-MS-TrafficTypeDiagnostic: SN1PR12MB2447: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wzfeyvnFwwagMuQearvb37WfwfviYdMMOmJ+XPToFLqRj5uJgwvzpgBcNTpQyBaXUaX1NYBE2Ji1O4Xh4tjFczSuUFH+/KD9E0ltk4LnXLJHRY9ERhFNVI4ykViwL+S+ubsrW0QmJvGz/CF4JDUho+CcS/l5EpbPd8RS93/JaIRxhO6SCPSzRuBeW3+J/JRzNrguW09SrvUa1iXEBOdzH/klfOLm9ZobjD/MeylqeFj3NXl6DdKvAidzbyvgXbPOz+GuPbc7c/tbf3zM4mtWJsCylf8NyNDXtziFAx1u+G0jHhsJAa/ck7kDsibmavGZGa44/DVCpHJgy1aFvfGPcGUQ4YAha8int6HA/rL+YgoZRoZhrs9HFjIMYPqU5wu/VBLAN/dOuVfWIauECsCaPUWn2fyu+zqcZz+OXudgNpRfIKXZlIHC9NnZ20fsYJp+81y+FKGEiCgNq6fnpuVTdxfLiLXwweAAt8K2nbE1ytK7j14VgYmacO/ui/E55BIR5jWAO6mrFHdjtL8Tx/4elVfSkOirgbcqWr9B9BXKD18330pEb2OtB5Bpe4ha/I5ZpGjzCbq2atP2ap/d06q4Ug0R70/VKQ5hvLLSnubJtrz3/vEw35KE2ihLEYxrCs/yxZiP3sJoDpkNGEXYquDkN+V5oTrtXu3xuTWRJCnjH9DzIPNIjtyktWBJPdfhKnm6AiP6FnVxPC18HuRqm5RemsBoUQSz6qdxt4Z0RpJjaVo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(16576012)(316002)(4744005)(31696002)(5660300002)(44832011)(2906002)(6486002)(956004)(36756003)(53546011)(186003)(2616005)(26005)(86362001)(38100700002)(66476007)(83380400001)(66556008)(54906003)(508600001)(8676002)(4326008)(8936002)(31686004)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cy92dFFOZitQRi83WmdmWjI5cjFqZzZadVRlMnBBWng4T0hjK3V0cVNoVXI1?= =?utf-8?B?dTFwTFIrV1J2M2lRWFh4YkJyTVBIMlUybWpTNXc0di9pU0RNTVFYNFFlZzg2?= =?utf-8?B?QitZaXUyc0pnN2NTUmJ1bWJMNTBWVUR3RXROQUJkaXpRRlF5WTBDSXhQcE9s?= =?utf-8?B?djNIZHNyWmhMWkRDeE40V3kxRFVuYlY0blgrNUVQRXc0WENLdWMvSDFmOW9w?= =?utf-8?B?dFBVWU5xSytVejVBaW1vMFp6bThURk5lcDlaSldLbHNkRUZOelJ3UkhSRzNN?= =?utf-8?B?Qjgrd3FISFY2ZE1taEpQd2tEaE52WkEyTkpuRVpIYkxNQ1M4NkdyaGwxcFI0?= =?utf-8?B?UmMvRVhPZnhnVTRGQ08wVnpFcFlJMkJUeDhubVJjMFZWYVdiV3ZPNnk5cjVs?= =?utf-8?B?UjJBVWs1R3hNYnBiL1c1anZPYnQ2TVdCNzNCZzNtM2c3MHpYRW9ERDlJQWpt?= =?utf-8?B?QUEwTTVhcERySmJSaThZdVlySGJpaDdJRWZ0U21rdVk3a2c5eHM5aUhxNkd5?= =?utf-8?B?NDdTVUU4b0kzWkgzYzNiaHNGRHhBVjlpQjV6NDd6bTRhd3Awd1cyVmxDdFpF?= =?utf-8?B?Mlo2cXh2SHg1d2R1WWIyeWZjSWovbW1uTjhFcVhST1JtcHcyMGNvd2dzSUNr?= =?utf-8?B?VnJRVUxrcVNxblFEcTJvcVAvSVJTaEUxenhZeVRmbXUyZVBJbWUzWFpxSXl5?= =?utf-8?B?dkdxZGVTZ3d2T1lnbTRZU25OdXArZ01DUjJpTW5ORmkraU9vL2RTczN5U1Q3?= =?utf-8?B?TGpGNHFkOWFoVUJtZjU5d0tkUEdkektuYWk2MkE5ZWszZHdnK09NQzQ4WGZV?= =?utf-8?B?aUl0M2tqaXhNeFMxNTNxOERHakxWbktXMHVpWlJaeXdFMzFWTjUrQmh0U0tw?= =?utf-8?B?K09zbGdTc2VwRTdVQVpzckFEMUQxODRHME8yVEZnd2pKSW1tdmxRaXdVVXNl?= =?utf-8?B?SVRoV1dkQ0V0TEZ1MkJhaGRVd3hZODY1Tm1lckFiMDd1azA2RG9IeG50anJx?= =?utf-8?B?amh5Z0J4SGZBMWFHV1hlVjhwL0poUnpDbXowUXVEcEU1UCtycU9ubCtabkNi?= =?utf-8?B?alBPaCtPdGdqTkpKUVdyVS9ZL05LcnV2SHBaZzUwYlpUbCtncllTTktOa2E3?= =?utf-8?B?ZndReUVjaXJvdUoyb3hjRWpzbFNPMTFPYzRFeHdJNXliUTRkcWc1NXBkT3Zk?= =?utf-8?B?QUlKbW55bEluWHRESlRVbGdIaW5XN1Q4d1lOMkp2NGNBMGNzK0NaYkxjTHJ1?= =?utf-8?B?aWRuMjU4NDFyU2ViU001WlhtUXZrNWNtNC8yOWZMb050YmVFQjJJdmNqN0Zw?= =?utf-8?B?YXdKMll6R0RzSmpFZGZUSW1RaGZJVWl5NW9jeE5KOGdycVFnSmY5UklSWE9S?= =?utf-8?B?Z011Nk15ZG5Zc1VBOTZSOXcvNEd1THYwTHViVVQrZGptUFFSRFFHM3g0T0Mw?= =?utf-8?B?SkcxcEhNS3ppZTl2Z1VqVWRnOXYyNlUzQlp6OXY2WDlrY0RMZENnd1I4UDVT?= =?utf-8?B?Ymt6SUU3b002UFVLcE1rd1p3UEh6K1RhMEVFQklsWkRwcjJFYlVxWjVNTUlF?= =?utf-8?B?UVQycndqQ1Y1d0wwOEZpa21HeUQwdm5UZldZTzFmS0dUc0dHRVNVM2haeU1a?= =?utf-8?B?cEQ3K0JJNm9Fendxak9YV1ZEb3BURFlOaWQybG9vSUJGTDFmbFgvZm1ESlRO?= =?utf-8?B?UkxSVER0S1dPSzJiVEh6NmV4bnpteG5PWWtHSEY2dVdQMUpVVmdFNTZQb0Rk?= =?utf-8?B?bW1mZWV4VGorSDRsUHhyVG1TUk9iRnVyTWYvVDBNZnlpaWtwNjFmcU9jL0dH?= =?utf-8?B?NElTYjQ1eHg2L29uZmZpbUVmVW41a1Qvd082a25aM0hJc3RjSEVad1hOM2lS?= =?utf-8?B?NHZXL0dVMG5GZEdxZDZja1VlZ0EyN1ppS2daM1YzaXJWU3BFOTJ1Tyt6WDhJ?= =?utf-8?B?T2MxWEdqYzJISFFJSVdZQVd2MmNLMUViajhmbHFpNWEvaHlCOVQ0dE53VWdQ?= =?utf-8?B?MFZIYzN6WmMwK0dqcUpleTV6dmNxV1hOSW9SR1RIKzROWmpUQ1RMU2pvQjQv?= =?utf-8?B?UXpBMitRVWdPblVuUGRxdU9wbVA2SWJxdWlWZEE0U0g1aDNIeTdjRFlKaE02?= =?utf-8?B?ck9uZlprNkVwNm40MFh6Vmx2WkZEUjRadE5mMGFpeEY0ZURvNjhub2pOZExI?= =?utf-8?Q?cTk9mqMBO/bbu/851qBOzJ4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 697ffc92-7474-4153-c81c-08d9b42562c1 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 17:18:11.5501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lk9mXOe0SYEDcwvRWqbIvSz8sQmA+435mXv8IMR6SIkdyjfeezEl0NmRr+8TOefxIo7U4S0qNexb+Cm97dIl+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2447 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/30/21 9:51 AM, Gerd Hoffmann wrote: > Hi, > >> What is missing in the original patch set is that now with the common work >> area we need to check the Guest Type before accessing the SevEs workarea >> type. I have a patch in my wip to cleanup the SEV feature detection check >> and patiently waiting for the SEV-SNP series to land so that I can submit >> other patches. > Can you prepare a version of the fix which does not depend on the snp > series and can be applied to edk2-stable202111? Ack. > thanks, > Gerd >