From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bibo Mao <maobibo@loongson.cn>, Chao Li <lichao@loongson.cn>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ling Jia <jialing@phytium.com.cn>,
Marcin Wojtas <mw@semihalf.com>,
Peng Xie <xiepeng@phytium.com.cn>,
Wenyi Xie <xiewenyi2@huawei.com>,
Xianglai li <lixianglai@loongson.cn>,
Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances
Date: Tue, 24 Oct 2023 15:20:56 +0200 [thread overview]
Message-ID: <c208dc83-0f3b-d37b-f9cf-98b703070092@redhat.com> (raw)
In-Reply-To: <20231020121903.44986-1-lersek@redhat.com>
On 10/20/23 14:18, Laszlo Ersek wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4565
>
> RealTimeClockLib instances should neither set gRT fields nor install
> EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize();
> EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (7):
> Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init
> steps
> LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init
> steps
> Hisilicon/M41T83RealTimeClockLib: remove superfluous instance init
> steps
> Hisilicon/RX8900RealTimeClockLib: remove superfluous instance init
> steps
> Silicon/Marvell/RealTimeClockLib: remove superfluous instance init
> steps
> FT2000-4Pkg/RealTimeClockLib: remove superfluous instance init steps
> Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps
>
> Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.c | 27 +++-----------------
> Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c | 16 ------------
> Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.inf | 3 ---
> Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c | 7 -----
> Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.c | 24 +++--------------
> Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 19 +-------------
> Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 13 ----------
> Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.c | 19 +-------------
> 8 files changed, 8 insertions(+), 120 deletions(-)
Commit range fdbe20318f27..b68199ec5895.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110007): https://edk2.groups.io/g/devel/message/110007
Mute This Topic: https://groups.io/mt/102079655/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-24 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 12:18 [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances Laszlo Ersek
2023-10-20 12:18 ` [edk2-devel] [edk2-platforms PATCH 1/7] Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init steps Laszlo Ersek
2023-10-20 12:18 ` [edk2-devel] [edk2-platforms PATCH 2/7] LoongArchQemuPkg/LsRealTimeClockLib: " Laszlo Ersek
2023-10-23 6:52 ` Chao Li
2023-10-20 12:18 ` [edk2-devel] [edk2-platforms PATCH 3/7] Hisilicon/M41T83RealTimeClockLib: " Laszlo Ersek
2023-10-20 12:19 ` [edk2-devel] [edk2-platforms PATCH 4/7] Hisilicon/RX8900RealTimeClockLib: " Laszlo Ersek
2023-10-20 12:19 ` [edk2-devel] [edk2-platforms PATCH 5/7] Silicon/Marvell/RealTimeClockLib: " Laszlo Ersek
2023-10-20 12:19 ` [edk2-devel] [edk2-platforms PATCH 6/7] FT2000-4Pkg/RealTimeClockLib: " Laszlo Ersek
2023-10-20 12:19 ` [edk2-devel] [edk2-platforms PATCH 7/7] Omap35xxPkg/RealTimeClockLib: " Laszlo Ersek
2023-10-20 12:26 ` [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances Ard Biesheuvel
2023-10-24 13:20 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c208dc83-0f3b-d37b-f9cf-98b703070092@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox