From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0E06874003E for ; Tue, 24 Oct 2023 13:21:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ntovEA8Cr9we8atjw+4yeSEZw45r/GqhOcSC4MgRYZI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698153674; v=1; b=vqyVQQRSQVmxiiJMYkQGvZMh2HY0025g+5SEPxt832BwvbC6Jno6bl6CLXDITTxKvw874bYE PWl2AmvQlMB1poVmEM90EjbriKw04W5NtGH1PBz1XfpioEIbc0pDsspBySqmQ8VfSfpHUMEwOrr RbBzS+WkPRD27ddt1xy3WETE= X-Received: by 127.0.0.2 with SMTP id RIurYY7687511xXRNbSas0At; Tue, 24 Oct 2023 06:21:14 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.147566.1698153673967223400 for ; Tue, 24 Oct 2023 06:21:14 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-JWzfzWkiN4q03aUZMDs8tQ-1; Tue, 24 Oct 2023 09:21:02 -0400 X-MC-Unique: JWzfzWkiN4q03aUZMDs8tQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1E62101A54C; Tue, 24 Oct 2023 13:21:01 +0000 (UTC) X-Received: from [10.39.195.39] (unknown [10.39.195.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E60A5C15BB8; Tue, 24 Oct 2023 13:20:57 +0000 (UTC) Message-ID: Date: Tue, 24 Oct 2023 15:20:56 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Bibo Mao , Chao Li , Leif Lindholm , Ling Jia , Marcin Wojtas , Peng Xie , Wenyi Xie , Xianglai li , Yiqi Shu Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20231020121903.44986-1-lersek@redhat.com> In-Reply-To: <20231020121903.44986-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BRUgQv5Q5DNdRDgVdyUOYoaXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vqyVQQRS; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/20/23 14:18, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4565 >=20 > RealTimeClockLib instances should neither set gRT fields nor install > EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize(); > EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions. >=20 > Cc: Ard Biesheuvel > Cc: Bibo Mao > Cc: Chao Li > Cc: Leif Lindholm > Cc: Ling Jia > Cc: Marcin Wojtas > Cc: Peng Xie > Cc: Wenyi Xie > Cc: Xianglai li > Cc: Yiqi Shu >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (7): > Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init > steps > LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init > steps > Hisilicon/M41T83RealTimeClockLib: remove superfluous instance init > steps > Hisilicon/RX8900RealTimeClockLib: remove superfluous instance init > steps > Silicon/Marvell/RealTimeClockLib: remove superfluous instance init > steps > FT2000-4Pkg/RealTimeClockLib: remove superfluous instance init steps > Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps >=20 > Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeCloc= kLib.c | 27 +++----------------- > Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTime= ClockLib.c | 16 ------------ > Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTime= ClockLib.inf | 3 --- > Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.= c | 7 ----- > Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.= c | 24 +++-------------- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c = | 19 +------------- > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c = | 13 ---------- > Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeCl= ockLib.c | 19 +------------- > 8 files changed, 8 insertions(+), 120 deletions(-) Commit range fdbe20318f27..b68199ec5895. Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110007): https://edk2.groups.io/g/devel/message/110007 Mute This Topic: https://groups.io/mt/102079655/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-