Re: [PATCH v4 0/7] Introduce two public functions and remove internal ones

[Laszlo Ersek <lersek@redhat.com>]

On 12/25/18 09:17, Shenglei Zhang wrote:
> Introduce public functions CharToUpper and AsciiToUpper.
> Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper.
> 
> v2: Update the title and commit message of 1/3.
> 
> v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c.
>     2.Revert the changes in Basetools.
> 
> v4: 1.Add1/7: Change function names in EdbSupportString.c.
>     2.Update the title of 4/7.
>     3.Add 5/7: Use BaseLib api AsciiToUpper in DxeHttpLib.c.
>     4.Add 6/7: Use BaseLib api CharToUpper in ShellManParser.c.
>     5.Add 7/7: Use BaseLib api CharToUpper in UefiShellLib.c.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Shenglei Zhang (7):
>   MdeModulePkg/EbcDebugger: Change function names
>   MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly
>   MdePkg/BaseLib: Remove InternalCharToUpper and
>     InternalBaseLibAsciiToUpper
>   MdeModulePkg/EbcDebugger: Use BaseLib apis AsciiToUpper and
>     CharToUpper
>   MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiToUpper
>   ShellPkg/Shell: Use BaseLib api CharToUpper
>   ShellPkg/UefiShellLib: Use BaseLib api CharToUpper


https://en.wikipedia.org/wiki/Email_bankruptcy

Please don't wait for my review of this set.

Thanks
Laszlo