From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 442E621164EF2 for ; Wed, 26 Dec 2018 12:11:23 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B280BBDF7; Wed, 26 Dec 2018 20:11:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-136.rdu2.redhat.com [10.10.121.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7E6919C7D; Wed, 26 Dec 2018 20:11:19 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Ruiyu Ni , Hao Wu , Jaben Carsey , Liming Gao , Michael D Kinney , Star Zeng References: <20181225081717.2776-1-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 26 Dec 2018 21:11:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181225081717.2776-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 26 Dec 2018 20:11:22 +0000 (UTC) Subject: Re: [PATCH v4 0/7] Introduce two public functions and remove internal ones X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2018 20:11:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/25/18 09:17, Shenglei Zhang wrote: > Introduce public functions CharToUpper and AsciiToUpper. > Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper. > > v2: Update the title and commit message of 1/3. > > v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c. > 2.Revert the changes in Basetools. > > v4: 1.Add1/7: Change function names in EdbSupportString.c. > 2.Update the title of 4/7. > 3.Add 5/7: Use BaseLib api AsciiToUpper in DxeHttpLib.c. > 4.Add 6/7: Use BaseLib api CharToUpper in ShellManParser.c. > 5.Add 7/7: Use BaseLib api CharToUpper in UefiShellLib.c. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Laszlo Ersek > Cc: Jian J Wang > Cc: Hao Wu > Cc: Star Zeng > Cc: Ruiyu Ni > Cc: Jaben Carsey > Shenglei Zhang (7): > MdeModulePkg/EbcDebugger: Change function names > MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly > MdePkg/BaseLib: Remove InternalCharToUpper and > InternalBaseLibAsciiToUpper > MdeModulePkg/EbcDebugger: Use BaseLib apis AsciiToUpper and > CharToUpper > MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiToUpper > ShellPkg/Shell: Use BaseLib api CharToUpper > ShellPkg/UefiShellLib: Use BaseLib api CharToUpper https://en.wikipedia.org/wiki/Email_bankruptcy Please don't wait for my review of this set. Thanks Laszlo